MDEV-17609 introduced a change to client/mysql.cc which is causing an error with clang on OSX. We discovered this in our CI building 10.4.8 from source.
The error we are seeing on OSX is:
mariadb-10.4.8/client/mysql.cc:2671:21: error: ISO C++11 does not allow conversion from string literal to 'char *' [-Werror,-Wwritable-strings]
|
rl_readline_name= "mysql";
|
It looks like this was fixed in 10.5 with a merge from 10.4. branch but I can't find the actual change included in the 10.4. branch.
https://github.com/MariaDB/server/commit/edef6a007428599fd249815f1dc59a02428090f4
rl_readline_name= (char *) "mysql";
|
The cast to `(char *)` is all that is needed to remove this error from OSX builds.
I will push a PR to github shortly with this fix for the 10.4 branch.
There are no comments yet on this issue.
{"report":{"fcp":819.5,"ttfb":207.89999997615814,"pageVisibility":"visible","entityId":79542,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":32,"apdex":1,"journeyId":"b844d277-473e-4a0b-be63-03050b840f87","navigationType":0,"readyForUser":921,"redirectCount":0,"resourceLoadedEnd":562.1999999284744,"resourceLoadedStart":215.69999992847443,"resourceTiming":[{"duration":4.100000023841858,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":215.69999992847443,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":215.69999992847443,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":219.79999995231628,"responseStart":0,"secureConnectionStart":0},{"duration":5.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":216,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":216,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":221.5,"responseStart":0,"secureConnectionStart":0},{"duration":218,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":216,"connectEnd":216,"connectStart":216,"domainLookupEnd":216,"domainLookupStart":216,"fetchStart":216,"redirectEnd":0,"redirectStart":0,"requestStart":227.69999992847443,"responseEnd":434,"responseStart":249.69999992847443,"secureConnectionStart":216},{"duration":7,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":216.19999992847443,"connectEnd":216.19999992847443,"connectStart":216.19999992847443,"domainLookupEnd":216.19999992847443,"domainLookupStart":216.19999992847443,"fetchStart":216.19999992847443,"redirectEnd":0,"redirectStart":0,"requestStart":216.19999992847443,"responseEnd":223.19999992847443,"responseStart":223.19999992847443,"secureConnectionStart":216.19999992847443},{"duration":346,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":216.19999992847443,"connectEnd":216.19999992847443,"connectStart":216.19999992847443,"domainLookupEnd":216.19999992847443,"domainLookupStart":216.19999992847443,"fetchStart":216.19999992847443,"redirectEnd":0,"redirectStart":0,"requestStart":228.10000002384186,"responseEnd":562.1999999284744,"responseStart":251.39999997615814,"secureConnectionStart":216.19999992847443},{"duration":32.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":216.29999995231628,"connectEnd":216.29999995231628,"connectStart":216.29999995231628,"domainLookupEnd":216.29999995231628,"domainLookupStart":216.29999995231628,"fetchStart":216.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":228.79999995231628,"responseEnd":248.79999995231628,"responseStart":246.10000002384186,"secureConnectionStart":216.29999995231628},{"duration":32.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":216.39999997615814,"connectEnd":216.39999997615814,"connectStart":216.39999997615814,"domainLookupEnd":216.39999997615814,"domainLookupStart":216.39999997615814,"fetchStart":216.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":229.10000002384186,"responseEnd":249,"responseStart":246.89999997615814,"secureConnectionStart":216.39999997615814},{"duration":10.399999976158142,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":216.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":216.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":226.89999997615814,"responseStart":0,"secureConnectionStart":0},{"duration":43.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":216.5,"connectEnd":216.5,"connectStart":216.5,"domainLookupEnd":216.5,"domainLookupStart":216.5,"fetchStart":216.5,"redirectEnd":0,"redirectStart":0,"requestStart":232.69999992847443,"responseEnd":260.10000002384186,"responseStart":256.60000002384186,"secureConnectionStart":216.5},{"duration":12,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":216.60000002384186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":216.60000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":228.60000002384186,"responseStart":0,"secureConnectionStart":0},{"duration":46.200000047683716,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":216.79999995231628,"connectEnd":216.79999995231628,"connectStart":216.79999995231628,"domainLookupEnd":216.79999995231628,"domainLookupStart":216.79999995231628,"fetchStart":216.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":233.19999992847443,"responseEnd":263,"responseStart":257.39999997615814,"secureConnectionStart":216.79999995231628},{"duration":282.8000000715256,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":234.19999992847443,"connectEnd":234.19999992847443,"connectStart":234.19999992847443,"domainLookupEnd":234.19999992847443,"domainLookupStart":234.19999992847443,"fetchStart":234.19999992847443,"redirectEnd":0,"redirectStart":0,"requestStart":270.10000002384186,"responseEnd":517,"responseStart":505.60000002384186,"secureConnectionStart":234.19999992847443},{"duration":279.6999999284744,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":239.10000002384186,"connectEnd":239.10000002384186,"connectStart":239.10000002384186,"domainLookupEnd":239.10000002384186,"domainLookupStart":239.10000002384186,"fetchStart":239.10000002384186,"redirectEnd":0,"redirectStart":0,"requestStart":283.89999997615814,"responseEnd":518.7999999523163,"responseStart":514,"secureConnectionStart":239.10000002384186},{"duration":113.89999997615814,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":578,"connectEnd":578,"connectStart":578,"domainLookupEnd":578,"domainLookupStart":578,"fetchStart":578,"redirectEnd":0,"redirectStart":0,"requestStart":650,"responseEnd":691.8999999761581,"responseStart":689.3999999761581,"secureConnectionStart":578},{"duration":110.19999992847443,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":780,"connectEnd":780,"connectStart":780,"domainLookupEnd":780,"domainLookupStart":780,"fetchStart":780,"redirectEnd":0,"redirectStart":0,"requestStart":856.8999999761581,"responseEnd":890.1999999284744,"responseStart":889.5,"secureConnectionStart":780},{"duration":43.89999997615814,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":813.3999999761581,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":813.3999999761581,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":857.2999999523163,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":39,"responseStart":208,"responseEnd":239,"domLoading":211,"domInteractive":968,"domContentLoadedEventStart":968,"domContentLoadedEventEnd":1011,"domComplete":1100,"loadEventStart":1100,"loadEventEnd":1100,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":953.6000000238419},{"name":"bigPipe.sidebar-id.end","time":954.2999999523163},{"name":"bigPipe.activity-panel-pipe-id.start","time":954.6000000238419},{"name":"bigPipe.activity-panel-pipe-id.end","time":954.8999999761581},{"name":"activityTabFullyLoaded","time":1015.8999999761581}],"measures":[],"correlationId":"593c4edbb54e6c","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":91,"dbReadsTimeInMs":11,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Bug
Minor