Type:
Task
Priority:
Major
Resolution:
Fixed
In order to simplify the unification of these Type_handler methods:
virtual Field *make_table_field(MEM_ROOT *root,
const LEX_CSTRING *name,
const Record_addr &addr,
const Type_all_attributes &attr,
TABLE *table) const = 0;
and
virtual Field *
make_table_field_from_def(TABLE_SHARE *share,
MEM_ROOT *mem_root,
const LEX_CSTRING *name,
const Record_addr &addr,
const Bit_addr &bit,
const Column_definition_attributes *attr,
uint32 flags) const = 0;
let's do the following:
Move Column_definition::decimals to the parent class Column_definition_attributes
When loading a column definition from a FRM file, instead of mixing numeric scale to Column_definition_attributes::pack_flag, store it to Column_definition_attributes::decimals. This will be done in virtual implementation of Type_handler_xxx::Column_definition_attributes_frm_unpack().
Mix (decimals << FIELDFLAG_DEC_SHIFT) to pack_flag only before storing it to the FRM. This will be done in virtual implementation of Type_handler_xxx::Column_definition_attributes_frm_pack().
As a result:
Column_definition_attributes::decimals will always be up-to-date.
Column_definition_attributes::pack_flag will never contain the decimal scale
blocks
MDEV-4912
Data type plugin API version 1
Closed
{"report":{"fcp":817.3000001907349,"ttfb":254.90000009536743,"pageVisibility":"visible","entityId":79373,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"3f14c9cb-8396-465d-8825-3ffab98513af","navigationType":0,"readyForUser":872,"redirectCount":0,"resourceLoadedEnd":546.4000000953674,"resourceLoadedStart":259.7000000476837,"resourceTiming":[{"duration":48.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":259.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":259.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":308.60000014305115,"responseStart":0,"secureConnectionStart":0},{"duration":49,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":259.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":259.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":308.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":104.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":259.90000009536743,"connectEnd":259.90000009536743,"connectStart":259.90000009536743,"domainLookupEnd":259.90000009536743,"domainLookupStart":259.90000009536743,"fetchStart":259.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":259.90000009536743,"responseEnd":364.30000019073486,"responseStart":364.30000019073486,"secureConnectionStart":259.90000009536743},{"duration":168.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":260.10000014305115,"connectEnd":260.10000014305115,"connectStart":260.10000014305115,"domainLookupEnd":260.10000014305115,"domainLookupStart":260.10000014305115,"fetchStart":260.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":260.10000014305115,"responseEnd":428.7000000476837,"responseStart":428.7000000476837,"secureConnectionStart":260.10000014305115},{"duration":172.10000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":260.2000000476837,"connectEnd":260.2000000476837,"connectStart":260.2000000476837,"domainLookupEnd":260.2000000476837,"domainLookupStart":260.2000000476837,"fetchStart":260.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":260.2000000476837,"responseEnd":432.30000019073486,"responseStart":432.30000019073486,"secureConnectionStart":260.2000000476837},{"duration":172.29999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":260.40000009536743,"connectEnd":260.40000009536743,"connectStart":260.40000009536743,"domainLookupEnd":260.40000009536743,"domainLookupStart":260.40000009536743,"fetchStart":260.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":260.40000009536743,"responseEnd":432.7000000476837,"responseStart":432.7000000476837,"secureConnectionStart":260.40000009536743},{"duration":172.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":260.40000009536743,"connectEnd":260.40000009536743,"connectStart":260.40000009536743,"domainLookupEnd":260.40000009536743,"domainLookupStart":260.40000009536743,"fetchStart":260.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":260.40000009536743,"responseEnd":433.10000014305115,"responseStart":433.10000014305115,"secureConnectionStart":260.40000009536743},{"duration":172.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":260.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":260.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":433.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":172.79999995231628,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":260.60000014305115,"connectEnd":260.60000014305115,"connectStart":260.60000014305115,"domainLookupEnd":260.60000014305115,"domainLookupStart":260.60000014305115,"fetchStart":260.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":260.60000014305115,"responseEnd":433.40000009536743,"responseStart":433.40000009536743,"secureConnectionStart":260.60000014305115},{"duration":173.20000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":260.7000000476837,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":260.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":433.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":173.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":260.7000000476837,"connectEnd":260.7000000476837,"connectStart":260.7000000476837,"domainLookupEnd":260.7000000476837,"domainLookupStart":260.7000000476837,"fetchStart":260.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":260.7000000476837,"responseEnd":434.10000014305115,"responseStart":434.10000014305115,"secureConnectionStart":260.7000000476837},{"duration":248.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":268.10000014305115,"connectEnd":268.10000014305115,"connectStart":268.10000014305115,"domainLookupEnd":268.10000014305115,"domainLookupStart":268.10000014305115,"fetchStart":268.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":268.10000014305115,"responseEnd":516.6000001430511,"responseStart":516.6000001430511,"secureConnectionStart":268.10000014305115},{"duration":277,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":269.40000009536743,"connectEnd":269.40000009536743,"connectStart":269.40000009536743,"domainLookupEnd":269.40000009536743,"domainLookupStart":269.40000009536743,"fetchStart":269.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":269.40000009536743,"responseEnd":546.4000000953674,"responseStart":546.4000000953674,"secureConnectionStart":269.40000009536743},{"duration":308.7000000476837,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":588.9000000953674,"connectEnd":588.9000000953674,"connectStart":588.9000000953674,"domainLookupEnd":588.9000000953674,"domainLookupStart":588.9000000953674,"fetchStart":588.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":588.9000000953674,"responseEnd":897.6000001430511,"responseStart":897.6000001430511,"secureConnectionStart":588.9000000953674},{"duration":102.90000009536743,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":795.9000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":795.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":898.8000001907349,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":125,"responseStart":255,"responseEnd":269,"domLoading":258,"domInteractive":926,"domContentLoadedEventStart":926,"domContentLoadedEventEnd":965,"domComplete":1323,"loadEventStart":1323,"loadEventEnd":1325,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":904.1000001430511},{"name":"bigPipe.sidebar-id.end","time":905},{"name":"bigPipe.activity-panel-pipe-id.start","time":905.2000000476837},{"name":"bigPipe.activity-panel-pipe-id.end","time":907.7000000476837},{"name":"activityTabFullyLoaded","time":974.8000001907349}],"measures":[],"correlationId":"37c0bb73a01ad7","effectiveType":"4g","downlink":9.4,"rtt":0,"serverDuration":74,"dbReadsTimeInMs":12,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}