Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20696

Remove Column_definition::key_length

Details

    Description

      Let's remove the member Column_definition::key_length and introduce a new virtual method in Type_handler instead:

      virtual uint calc_key_length(const Column_definition &def) const;

      Note, key_length is a redundant member. It can be unambiguously calculated, depending on the data type, from:

      • Column_definition::pack_length
      • Column_definition::length
      • Column_definition::interval

      There is no a need to copy this member around the code.

      Removing key_length will simplify the job being done in Type_handler methods:

      • Column_definition_prepare_stage1()
      • Column_definition_redefine_stage1()

      which will give a simpler data type API.

      Also, later this change will simplify to unify these Type_handler methods:

         virtual Field *make_table_field(MEM_ROOT *root,
      		 
                                        const LEX_CSTRING *name,
      		 
                                        const Record_addr &addr,
      		 
                                        const Type_all_attributes &attr,
      		 
                                        TABLE *table) const= 0;

      and

        virtual Field *
      		 
        make_table_field_from_def(TABLE_SHARE *share,
      		 
                                  MEM_ROOT *mem_root,
      		 
                                  const LEX_CSTRING *name,
      		 
                                  const Record_addr &addr,
      		 
                                  const Bit_addr &bit,
      		 
                                  const Column_definition_attributes *attr,
      		 
                                  uint32 flags) const= 0;

      into a single method.

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Rank Ranked higher
            bar Alexander Barkov made changes -
            Description Let's remove the member Column_definition::key_length and introduce a new virtual method in Type_handler instead:

            {code:cpp}
            virtual uint calc_key_length(const Column_definition &def) const;
            {code}

            It will simplify to unify these Type_handler methods:
            {code:cpp}
               virtual Field *make_table_field(MEM_ROOT *root,
                                              const LEX_CSTRING *name,
                                              const Record_addr &addr,
                                              const Type_all_attributes &attr,
                                              TABLE *table) const= 0;
            {code}
            and
            {code:cpp}
              virtual Field *
              make_table_field_from_def(TABLE_SHARE *share,
                                        MEM_ROOT *mem_root,
                                        const LEX_CSTRING *name,
                                        const Record_addr &addr,
                                        const Bit_addr &bit,
                                        const Column_definition_attributes *attr,
                                        uint32 flags) const= 0;
            {code}
            into a single method.
            		Let's remove the member Column_definition::key_length and introduce a new virtual method in Type_handler instead:

            {code:cpp}
            virtual uint calc_key_length(const Column_definition &def) const;
            {code}

            Note, key_length is a redundant member. It can be unambiguously calculated, depending on the data type, from:
            - Column_definition::pack_length
            - Column_definition::length
            - Column_definition::interval

            There is no a need to copy this member around the code.

            Removing key_length will simplify the job being done in Type_handler methods:
            - Column_definition_prepare_stage1()
            - Column_definition_redefine_stage1()
            which gives a simpler data type API.


            Also, later this change will simplify to unify these Type_handler methods:
            {code:cpp}
               virtual Field *make_table_field(MEM_ROOT *root,
                                              const LEX_CSTRING *name,
                                              const Record_addr &addr,
                                              const Type_all_attributes &attr,
                                              TABLE *table) const= 0;
            {code}
            and
            {code:cpp}
              virtual Field *
              make_table_field_from_def(TABLE_SHARE *share,
                                        MEM_ROOT *mem_root,
                                        const LEX_CSTRING *name,
                                        const Record_addr &addr,
                                        const Bit_addr &bit,
                                        const Column_definition_attributes *attr,
                                        uint32 flags) const= 0;
            {code}
            into a single method.
            bar Alexander Barkov made changes -
            Description Let's remove the member Column_definition::key_length and introduce a new virtual method in Type_handler instead:

            {code:cpp}
            virtual uint calc_key_length(const Column_definition &def) const;
            {code}

            Note, key_length is a redundant member. It can be unambiguously calculated, depending on the data type, from:
            - Column_definition::pack_length
            - Column_definition::length
            - Column_definition::interval

            There is no a need to copy this member around the code.

            Removing key_length will simplify the job being done in Type_handler methods:
            - Column_definition_prepare_stage1()
            - Column_definition_redefine_stage1()
            which gives a simpler data type API.


            Also, later this change will simplify to unify these Type_handler methods:
            {code:cpp}
               virtual Field *make_table_field(MEM_ROOT *root,
                                              const LEX_CSTRING *name,
                                              const Record_addr &addr,
                                              const Type_all_attributes &attr,
                                              TABLE *table) const= 0;
            {code}
            and
            {code:cpp}
              virtual Field *
              make_table_field_from_def(TABLE_SHARE *share,
                                        MEM_ROOT *mem_root,
                                        const LEX_CSTRING *name,
                                        const Record_addr &addr,
                                        const Bit_addr &bit,
                                        const Column_definition_attributes *attr,
                                        uint32 flags) const= 0;
            {code}
            into a single method.
            		Let's remove the member Column_definition::key_length and introduce a new virtual method in Type_handler instead:

            {code:cpp}
            virtual uint calc_key_length(const Column_definition &def) const;
            {code}

            Note, key_length is a redundant member. It can be unambiguously calculated, depending on the data type, from:
            - Column_definition::pack_length
            - Column_definition::length
            - Column_definition::interval

            There is no a need to copy this member around the code.

            Removing key_length will simplify the job being done in Type_handler methods:
            - Column_definition_prepare_stage1()
            - Column_definition_redefine_stage1()

            which will give a simpler data type API.


            Also, later this change will simplify to unify these Type_handler methods:
            {code:cpp}
               virtual Field *make_table_field(MEM_ROOT *root,
                                              const LEX_CSTRING *name,
                                              const Record_addr &addr,
                                              const Type_all_attributes &attr,
                                              TABLE *table) const= 0;
            {code}
            and
            {code:cpp}
              virtual Field *
              make_table_field_from_def(TABLE_SHARE *share,
                                        MEM_ROOT *mem_root,
                                        const LEX_CSTRING *name,
                                        const Record_addr &addr,
                                        const Bit_addr &bit,
                                        const Column_definition_attributes *attr,
                                        uint32 flags) const= 0;
            {code}
            into a single method.
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2019-09-30 02:36:42.0 2019-09-30 02:36:42.286
            bar Alexander Barkov made changes -
            Fix Version/s 10.5.0 [ 23709 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 100042 ] MariaDB v4 [ 134100 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.