Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20601

Make REPLICA a synonym for SLAVE in SQL statements

Details

    Description

      This could be done in the parser (don't forget to change both default and oracle-mode parsers), with a rule

      slave_or_replica: SLAVE | REPLICA_SYM ;

      or in the lexer, with one-liner in lex.h

          { "REPLICA",  SYM(SLAVE)},

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24362 Privilege aliases are missing from SHOW PRIVILEGES

          • Major - Major loss of function.
          • Open
          is part of

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-18777 Rename or alias slave-related statements, options, status variables

          • Major - Major loss of function.
          • Stalled

          Activity

            Ascending order - Click to sort in descending order
            serg Sergei Golubchik created issue -
            serg Sergei Golubchik made changes -
            Field Original Value New Value
            serg Sergei Golubchik made changes -
            Description This could be done in the parser, with a rule
            {code:yacc}
            slave_or_replica: SLAVE | REPLICA_SYM ;
            {code}
            or in the lexer, with one-liner
            {code:c}
                { "REPLICA", SYM(SLAVE)},
            {code}             		This could be done in the parser, with a rule
            {code:yacc}
            slave_or_replica: SLAVE | REPLICA_SYM ;
            {code}
            or in the lexer, with one-liner in {{lex.h}}
            {code:c}
                { "REPLICA", SYM(SLAVE)},
            {code}
            serg Sergei Golubchik made changes -
            Description This could be done in the parser, with a rule
            {code:yacc}
            slave_or_replica: SLAVE | REPLICA_SYM ;
            {code}
            or in the lexer, with one-liner in {{lex.h}}
            {code:c}
                { "REPLICA", SYM(SLAVE)},
            {code}             		This could be done in the parser (don't forget to change both normal and oracle-mode parsers), with a rule
            {code:yacc}
            slave_or_replica: SLAVE | REPLICA_SYM ;
            {code}
            or in the lexer, with one-liner in {{lex.h}}
            {code:c}
                { "REPLICA", SYM(SLAVE)},
            {code}
            serg Sergei Golubchik made changes -
            Description This could be done in the parser (don't forget to change both normal and oracle-mode parsers), with a rule
            {code:yacc}
            slave_or_replica: SLAVE | REPLICA_SYM ;
            {code}
            or in the lexer, with one-liner in {{lex.h}}
            {code:c}
                { "REPLICA", SYM(SLAVE)},
            {code}             		This could be done in the parser (don't forget to change both default and oracle-mode parsers), with a rule
            {code:yacc}
            slave_or_replica: SLAVE | REPLICA_SYM ;
            {code}
            or in the lexer, with one-liner in {{lex.h}}
            {code:c}
                { "REPLICA", SYM(SLAVE)},
            {code}
            sujatha.sivakumar Sujatha Sivakumar (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment -

            Hello Andrei,

            Please review the changes for MDEV-20601.

            Patch: https://github.com/MariaDB/server/commit/23686b2bafe2f3f9614d68923dfd4aea7641dbcc

            BuildBot Results: http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.5-sujatha

            Thank you.

            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment - Hello Andrei, Please review the changes for MDEV-20601 . Patch: https://github.com/MariaDB/server/commit/23686b2bafe2f3f9614d68923dfd4aea7641dbcc BuildBot Results: http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.5-sujatha Thank you.
            sujatha.sivakumar Sujatha Sivakumar (Inactive) made changes -
            Assignee Sujatha Sivakumar [ sujatha.sivakumar ] Andrei Elkin [ elkin ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            Elkin Andrei Elkin added a comment -

            Thanks for the patch!

            Elkin Andrei Elkin added a comment - Thanks for the patch!
            Elkin Andrei Elkin made changes -
            Assignee Andrei Elkin [ elkin ] Sujatha Sivakumar [ sujatha.sivakumar ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment -

            Fix is implemented in 10.5.1

            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment - Fix is implemented in 10.5.1
            sujatha.sivakumar Sujatha Sivakumar (Inactive) made changes -
            issue.field.resolutiondate 2020-02-04 12:49:14.0 2020-02-04 12:49:14.798
            sujatha.sivakumar Sujatha Sivakumar (Inactive) made changes -
            Fix Version/s 10.5.1 [ 24029 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            GeoffMontee Geoff Montee (Inactive) made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 99689 ] MariaDB v4 [ 134091 ]
            mariadb-jira-automation Jira Automation (IT) made changes -
            Zendesk Related Tickets 199205

            People

              sujatha.sivakumar Sujatha Sivakumar (Inactive)
              serg Sergei Golubchik
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.