Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20321

TokuDB debug printed in prod log

    XMLWordPrintable

Details

    Description

      Hi,

      When a server containing TokuDB tables is shutdown, debug stuff is logged:

      24590 /home/buildbot/buildbot/build/mariadb-10.2.26/storage/tokudb/ha_tokudb.cc:161 static_destroy _open_tables ./optizy_saas/planning 0x7f0511798008
      24590 /home/buildbot/buildbot/build/mariadb-10.2.26/storage/tokudb/ha_tokudb.cc:161 static_destroy _open_tables ./optizy_saas/script_stats 0x7f050bee7008
      24590 /home/buildbot/buildbot/build/mariadb-10.2.26/storage/tokudb/ha_tokudb.cc:161 static_destroy _open_tables ./optizy_saas/server_stats 0x7f050bf81008

      There's indeed no check for debug in the code:

      TOKUDB_TRACE("_open_tables %s %p", it->first.c_str(), it->second);

      I would have expected:

      if (TOKUDB_UNLIKELY(tokudb::sysvars::debug))
      TOKUDB_TRACE("_open_tables %s %p", it->first.c_str(), it->second);

      instead

      BR,
      Jocelyn

      Attachments

        Activity

          People

            Unassigned Unassigned
            joce jocelyn fournier
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.