Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20215

binlog.show_concurrent_rotate failed in buildbot with wrong result

Details

    Description

      http://buildbot.askmonty.org/buildbot/builders/kvm-rpm-centos74-amd64-debug/builds/2379

      10.4 1c27eb7ebd2c95008ba9b4fdfdee4061

      binlog.show_concurrent_rotate 'row'      w1 [ fail ]
              Test ended at 2019-07-29 11:46:47
       
      CURRENT_TEST: binlog.show_concurrent_rotate
      --- /usr/share/mysql-test/suite/binlog/r/show_concurrent_rotate.result	2019-07-29 09:56:59.000000000 +0000
      +++ /dev/shm/var/1/log/show_concurrent_rotate.reject	2019-07-29 11:46:47.623678871 +0000
      @@ -12,5 +12,4 @@
       # The correct result must consists of two records
       Log_name	File_size
       master-bin.000001	#
      -master-bin.000002	#
       SET debug_sync = 'reset';
       
      mysqltest: Result length mismatch
      

      Attachments

        Activity

          alice Alice Sherepa added a comment - also on 10.5 https://buildbot.askmonty.org/buildbot/builders/kvm-fulltest2/builds/25407/steps/mtr_ps/logs/stdio

          This is ready for review

          The patch

          Buildbot

          bnestere Brandon Nesterenko added a comment - This is ready for review The patch Buildbot
          Elkin Andrei Elkin added a comment -

          Review notes are on github.

          Elkin Andrei Elkin added a comment - Review notes are on github.

          Hi Andrei!

          I have addressed your comments and the patch is ready for re-review.

          Github: f7aa91e1dfab6f951b7a03ea3fc6a230c696d944

          Buildbot: bb-10.4-MDEV-20215

          bnestere Brandon Nesterenko added a comment - Hi Andrei! I have addressed your comments and the patch is ready for re-review. Github: f7aa91e1dfab6f951b7a03ea3fc6a230c696d944 Buildbot: bb-10.4-MDEV-20215
          Elkin Andrei Elkin added a comment -

          The latest patch is good, but one piece of cleanup is needed.
          Upon fixing that, please proceed straight to pushing.

          Thanks a lot for a good piece of analysis and coding!

          Elkin Andrei Elkin added a comment - The latest patch is good, but one piece of cleanup is needed. Upon fixing that, please proceed straight to pushing. Thanks a lot for a good piece of analysis and coding!

          Cherry-picking this patch from 10.5-10.7 resulted in no merge conflicts.

          bnestere Brandon Nesterenko added a comment - Cherry-picking this patch from 10.5-10.7 resulted in no merge conflicts.

          People

            bnestere Brandon Nesterenko
            elenst Elena Stepanova
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.