Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-202

Overlays do not support nested test suites which exist in MTR

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.5.21
    • Fix Version/s: 5.5.23
    • Component/s: None
    • Labels:
      None

      Description

      MTR supports nested test suites, such as suite/engines/funcs.
      It is run by providing the suite value as

      --suite=engines/funcs.

      Overlays do not support this. If I create storage/<engine>/mysql-test/engines/funcs and then run

      perl mtr --suite=engines/funcs- 

      it dies at lib/mtr_cases.pm line 383.

      It seems that the change below fixes it, although I might fail to predict some deeper consequences.

      @@ -380,7 +380,7 @@
           local %file_combinations = ();
           local %file_in_overlay = ();
       
      -    die unless m@/(?:storage|plugin)/(\w+)/mysql-test/\w+$@;
      +    die "Overlay not found" unless m@/(?:storage|plugin)/(\w+)/mysql-test/[\w\\\/]+$@;
           next unless defined $over and ($over eq '' or $over eq $1);
           push @cases, 
           # don't add cases that take *all* data from the parent suite

      Please replace the death message with something appropriate, but it's better to say something than die quietly.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                serg Sergei Golubchik
                Reporter:
                elenst Elena Stepanova
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: