Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20119

Implement the --do-domain-ids, --ignore-domain-ids, and --ignore-server-ids options for mysqlbinlog

Details

    Description

      In addition to the features requested in MDEV-4989, it would also be helpful to filter GTIDs based on specific gtid_domain_id values when using mysqlbinlog. To do this, mysqlbinlog could have the --do-domain-ids, --ignore-domain-ids, and --ignore-server-ids options, which would be similar to the DO_DOMAIN_IDS, IGNORE_DOMAIN_IDS, and IGNORE_SERVER_IDS options available for CHANGE MASTER TO.

      https://mariadb.com/kb/en/library/change-master-to/#do_domain_ids

      https://mariadb.com/kb/en/library/change-master-to/#ignore_domain_ids

      https://mariadb.com/kb/en/library/change-master-to/#ignore_server_ids

      From the commit message:
      "For completeness, this patch additionally adds the option --do-server-ids as an alias for
      --server-id, which now accepts a list of server ids instead of a
      single one."

      Attachments

        Issue Links

          is part of

          Task - A task that needs to be done. MDEV-28112 prepare 10.9.0 preview releases

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-4989 Support for GTID in mysqlbinlog

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-22905 Support DO_DOMAIN_IDS and IGNORE_DOMAIN_IDS in replication handshake

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. MXS-2581 Support DO_DOMAIN_IDS and IGNORE_DOMAIN_IDS for the Binlog Router

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MXS-2589 Adapt binlog router to

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bnestere Brandon Nesterenko added a comment -

            Hi Andrei,

            This relies on some ground-work laid by MDEV-4989, so it pends your review of that, but it is good for review otherwise.

            Commit: 85214cb4f7386bf10aa20fa7d97c2a46cb926001

            Buildbot: bb-10.7-MDEV-20119

            bnestere Brandon Nesterenko added a comment - Hi Andrei, This relies on some ground-work laid by MDEV-4989 , so it pends your review of that, but it is good for review otherwise. Commit: 85214cb4f7386bf10aa20fa7d97c2a46cb926001 Buildbot: bb-10.7-MDEV-20119
            bnestere Brandon Nesterenko added a comment -

            Changing status back to in progress to update with MDEV-4989 comments.

            bnestere Brandon Nesterenko added a comment - Changing status back to in progress to update with MDEV-4989 comments.
            bnestere Brandon Nesterenko added a comment - - edited

            Hi Andrei! This is ready for review

            Commit: b8e3790bd5f9ee
            BB: bb-10.9-MDEV-20119

            Edit: Updated commit to account for gtid-strict-mode fixes

            bnestere Brandon Nesterenko added a comment - - edited Hi Andrei! This is ready for review Commit: b8e3790 bd5f9ee BB: bb-10.9-MDEV-20119 Edit: Updated commit to account for gtid-strict-mode fixes
            angelique.sklavounos Angelique Sklavounos (Inactive) added a comment -

            OK to push.

            angelique.sklavounos Angelique Sklavounos (Inactive) added a comment - OK to push.
            bnestere Brandon Nesterenko added a comment -

            Final commit: c132bce

            bnestere Brandon Nesterenko added a comment - Final commit: c132bce

            People

              bnestere Brandon Nesterenko
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.