Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20016

Add MariaDB_DATA_TYPE_PLUGIN

Details

    Description

      Let's add a new plugin type: MariaDB_DATA_TYPE_PLUGIN.

      plugin->data of such plugin will point to a single Type_handler implementation. So looking up a pluggable data type by name should be done very easy, by this code block:

        if ((plugin= my_plugin_lock_by_name(thd, &name, MariaDB_DATA_TYPE_PLUGIN)))
      		 
        {
      		 
          /*
      		 
            INSTALL PLUGIN is not fully supported for data type plugins yet.
      		 
            Fow now we have only mandatory built-in plugins
      		 
            and dynamic plugins for test purposes,
      		 
            Should be safe to unlock the plugin immediately.
      		 
          */
      		 
          const Type_handler *ph= reinterpret_cast<const Type_handler*>
      		 
                                  (plugin_ref_to_int(plugin)->data);
      		 
          plugin_unlock(thd, plugin);
      		 
          return ph;
      		 
        }

      Note, as the above comment states, for now we assume we have:

      • mandatory built-in plugins
      • dynamic test plugins, used by MTR in a single-thread environment
        so locking (incrementing and decrementing use count) is out of scope of this task and will be done separately.

      Under terms of this task let's implement a simple test plugin implementing an alias for an existing data type, to demonstrate that the plugin data type is understood in various contexts:

      • CREATE TABLE t1 (a XXX)
      • CAST(expr AS XXX)
      • CREATE FUNCTION f1() RETURNS XXX
      • DECLARE a XXX; – SP variable declarations

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. MDEV-20841 Turn GIS implementation into a plugin

          • Major - Major loss of function.
          • Open
          is blocked by

          Task - A task that needs to be done. MDEV-20052 Add a MEM_ROOT pointer argument to Type_handler::make_xxx_field()

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-20721 Implement sql_type() for Field_real and Field_int

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-20734 Allow reserved keywords as user defined type names

          • Major - Major loss of function.
          • Closed
          relates to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Rank Ranked higher
            bar Alexander Barkov made changes -
            Description Let's add a new plugin type: MariaDB_DATA_TYPE_PLUGIN.

            plugin->data of such plugin will point to a single Type_handler implementation. So looking up a pluggable data type by name should be done very easy, by this code block:
            {code:cpp}
              if ((plugin= my_plugin_lock_by_name(thd, &name, MariaDB_DATA_TYPE_PLUGIN)))
              {
                /*
                  INSTALL PLUGIN is not fully supported for data type plugins yet.
                  Fow now we have only mandatory built-in plugins
                  and dynamic plugins for test purposes,
                  Should be safe to unlock the plugin immediately.
                */
                const Type_handler *ph= reinterpret_cast<const Type_handler*>
                                        (plugin_ref_to_int(plugin)->data);
                plugin_unlock(thd, plugin);
                return ph;
              }

            {code}

            Note, as the above comment states, for now we assume we have:
            - mandatory built-in plugins
            - dynamic test plugins, used by MTR in a single-thread environment
            so locking (incrementing and decrementing use count) is out of scope of this task and will be done separately.

            Under terms of this task let's implement a simple test plugin implementing an alias for an existing data type, to demonstrate that the plugin data type is understood in various contexts:
            - CREATE TABLE
            - CAST
            - CREATE FUNCTION ... RETURNS
            - SP variable declarations


            		Let's add a new plugin type: MariaDB_DATA_TYPE_PLUGIN.

            plugin->data of such plugin will point to a single Type_handler implementation. So looking up a pluggable data type by name should be done very easy, by this code block:
            {code:cpp}
              if ((plugin= my_plugin_lock_by_name(thd, &name, MariaDB_DATA_TYPE_PLUGIN)))
              {
                /*
                  INSTALL PLUGIN is not fully supported for data type plugins yet.
                  Fow now we have only mandatory built-in plugins
                  and dynamic plugins for test purposes,
                  Should be safe to unlock the plugin immediately.
                */
                const Type_handler *ph= reinterpret_cast<const Type_handler*>
                                        (plugin_ref_to_int(plugin)->data);
                plugin_unlock(thd, plugin);
                return ph;
              }

            {code}

            Note, as the above comment states, for now we assume we have:
            - mandatory built-in plugins
            - dynamic test plugins, used by MTR in a single-thread environment
            so locking (incrementing and decrementing use count) is out of scope of this task and will be done separately.

            Under terms of this task let's implement a simple test plugin implementing an alias for an existing data type, to demonstrate that the plugin data type is understood in various contexts:
            - {{CREATE TABLE t1 (a XXX)}}
            - {{CAST(expr AS XXX)}}
            - {{CREATE FUNCTION f1() RETURNS XXX}}
            - {{DECLARE a XXX}}; -- SP variable declarations


            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            bar Alexander Barkov made changes -
            Assignee Alexander Barkov [ bar ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Alexander Barkov [ bar ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            bar Alexander Barkov made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            bar Alexander Barkov made changes -
            Assignee Alexander Barkov [ bar ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Alexander Barkov [ bar ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            Fix Version/s 10.5.0 [ 23709 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 98140 ] MariaDB v4 [ 134040 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.