Type:
Task
Priority:
Major
Resolution:
Fixed
To turn the implementation of the GIS data types into a plugin easier, let move Field_geom from field.h and field.cc to sql_type_geom.h and sql_type_geom.cc.
Let's also cleanup the code in the way that Field_geom is used only in
sql_type_geom.h - the class definition
sql_type_geom.cc - the class implementation, and use cases from Type_handler_geometry
item_geofunc.cc - in Item_func_spatial_rel::get_mm_leaf()
Field_geom is currently used in storage/mroonga/ha_mroonga.cpp, in cast targets. All casts targets should be changed to Field_blob, as the rest of the code uses nothing Field_geom specific.
Field_geom is also used in handler.h, in this method:
virtual bool can_convert_geom( const Field_geom *field,
const Column_definition &new_type) const
{
return false ;
}
Note, this method is not overloaded by any engines at the moment. So it can be removed for now. When engines will want to do instant ALTER for GEOMETRY (for example from POINT to GEOMETRY), we can restore this method, but using some generic pointer type instead of Field_geom.
{"report":{"fcp":3064.2999992370605,"ttfb":170.79999923706055,"pageVisibility":"visible","entityId":77415,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"0375f382-d681-47b2-800a-c755cbe5ead3","navigationType":0,"readyForUser":3132.5,"redirectCount":0,"resourceLoadedEnd":3218.3999996185303,"resourceLoadedStart":186,"resourceTiming":[{"duration":2386.0999994277954,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":186,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":186,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2572.0999994277954,"responseStart":0,"secureConnectionStart":0},{"duration":2386.2000007629395,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":186.29999923706055,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":186.29999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2572.5,"responseStart":0,"secureConnectionStart":0},{"duration":2427.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":186.5,"connectEnd":186.5,"connectStart":186.5,"domainLookupEnd":186.5,"domainLookupStart":186.5,"fetchStart":186.5,"redirectEnd":0,"redirectStart":0,"requestStart":186.5,"responseEnd":2613.8999996185303,"responseStart":2613.8999996185303,"secureConnectionStart":186.5},{"duration":2524.0999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":186.69999980926514,"connectEnd":186.69999980926514,"connectStart":186.69999980926514,"domainLookupEnd":186.69999980926514,"domainLookupStart":186.69999980926514,"fetchStart":186.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":186.69999980926514,"responseEnd":2710.7999992370605,"responseStart":2710.7999992370605,"secureConnectionStart":186.69999980926514},{"duration":2527.800000190735,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":186.89999961853027,"connectEnd":186.89999961853027,"connectStart":186.89999961853027,"domainLookupEnd":186.89999961853027,"domainLookupStart":186.89999961853027,"fetchStart":186.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":186.89999961853027,"responseEnd":2714.699999809265,"responseStart":2714.699999809265,"secureConnectionStart":186.89999961853027},{"duration":2528.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":187.0999994277954,"connectEnd":187.0999994277954,"connectStart":187.0999994277954,"domainLookupEnd":187.0999994277954,"domainLookupStart":187.0999994277954,"fetchStart":187.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":187.0999994277954,"responseEnd":2715.199999809265,"responseStart":2715.199999809265,"secureConnectionStart":187.0999994277954},{"duration":2529,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":187.29999923706055,"connectEnd":187.29999923706055,"connectStart":187.29999923706055,"domainLookupEnd":187.29999923706055,"domainLookupStart":187.29999923706055,"fetchStart":187.29999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":187.29999923706055,"responseEnd":2716.2999992370605,"responseStart":2716.2999992370605,"secureConnectionStart":187.29999923706055},{"duration":2569.800000190735,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":187.39999961853027,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":187.39999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2757.199999809265,"responseStart":0,"secureConnectionStart":0},{"duration":2529.699999809265,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":187.5999994277954,"connectEnd":187.5999994277954,"connectStart":187.5999994277954,"domainLookupEnd":187.5999994277954,"domainLookupStart":187.5999994277954,"fetchStart":187.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":187.5999994277954,"responseEnd":2717.2999992370605,"responseStart":2717.2999992370605,"secureConnectionStart":187.5999994277954},{"duration":2569.6000003814697,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":187.79999923706055,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":187.79999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2757.3999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":2530.6000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":187.89999961853027,"connectEnd":187.89999961853027,"connectStart":187.89999961853027,"domainLookupEnd":187.89999961853027,"domainLookupStart":187.89999961853027,"fetchStart":187.89999961853027,"redirectEnd":0,"redirectStart":0,"requestStart":187.89999961853027,"responseEnd":2718.5,"responseStart":2718.5,"secureConnectionStart":187.89999961853027},{"duration":3019.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":188.69999980926514,"connectEnd":188.69999980926514,"connectStart":188.69999980926514,"domainLookupEnd":188.69999980926514,"domainLookupStart":188.69999980926514,"fetchStart":188.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":188.69999980926514,"responseEnd":3208.0999994277954,"responseStart":3208.0999994277954,"secureConnectionStart":188.69999980926514},{"duration":3029.6000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":188.79999923706055,"connectEnd":188.79999923706055,"connectStart":188.79999923706055,"domainLookupEnd":188.79999923706055,"domainLookupStart":188.79999923706055,"fetchStart":188.79999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":188.79999923706055,"responseEnd":3218.3999996185303,"responseStart":3218.3999996185303,"secureConnectionStart":188.79999923706055},{"duration":440.79999923706055,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":2768.5,"connectEnd":2768.5,"connectStart":2768.5,"domainLookupEnd":2768.5,"domainLookupStart":2768.5,"fetchStart":2768.5,"redirectEnd":0,"redirectStart":0,"requestStart":2768.5,"responseEnd":3209.2999992370605,"responseStart":3209.2999992370605,"secureConnectionStart":2768.5},{"duration":177.80000019073486,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":3056.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":3056.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":3234.699999809265,"responseStart":0,"secureConnectionStart":0}],"fetchStart":1,"domainLookupStart":1,"domainLookupEnd":1,"connectStart":1,"connectEnd":1,"requestStart":25,"responseStart":171,"responseEnd":185,"domLoading":184,"domInteractive":3236,"domContentLoadedEventStart":3236,"domContentLoadedEventEnd":3273,"domComplete":4490,"loadEventStart":4490,"loadEventEnd":4492,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":3220.5999994277954},{"name":"bigPipe.sidebar-id.end","time":3221.3999996185303},{"name":"bigPipe.activity-panel-pipe-id.start","time":3221.5999994277954},{"name":"bigPipe.activity-panel-pipe-id.end","time":3223.699999809265},{"name":"activityTabFullyLoaded","time":3277.3999996185303}],"measures":[],"correlationId":"a2d9d1e48ea9bd","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":85,"dbReadsTimeInMs":8,"dbConnsTimeInMs":15,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}