Type:
Bug
Priority:
Major
Resolution:
Fixed
Affects Version/s:
5.5(EOL) , 10.1(EOL) , 10.2(EOL) , 10.3(EOL) , 10.4(EOL) , 10.5
int handler::ha_write_row(uchar * buf);
This interface clearly states that storage engine is allowed to modify memory where buf points.
It was used in native InnoDB system versioned tables and I fixed two bugs on that topic. One is MDEV-19486 and another one is not mentioned in Jira.
Actually, calling code for `handler::ha_write_row()` is not prepared to buffer change by engine. I see not places in the code where it's used now. Thus I see no reason on having a mutable argument here.
I'll make it const to prevent future bugs.
relates to
MDEV-19486
Server crashes in row_upd or row_upd_del_mark_clust_rec on REPLACE into a versioned table
Closed
Transition
Time In Source Status
Execution Times
Open
Closed
20h 42m
1
{"report":{"fcp":1854.0999999046326,"ttfb":235.7999997138977,"pageVisibility":"visible","entityId":77321,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"1c2fdb26-3b3a-41ac-8f44-77cb8af89fc5","navigationType":0,"readyForUser":1959.5999999046326,"redirectCount":0,"resourceLoadedEnd":1936.6999998092651,"resourceLoadedStart":305.40000009536743,"resourceTiming":[{"duration":82.2999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":305.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":305.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":387.69999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":82.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":305.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":305.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":388,"responseStart":0,"secureConnectionStart":0},{"duration":1024.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":305.90000009536743,"connectEnd":305.90000009536743,"connectStart":305.90000009536743,"domainLookupEnd":305.90000009536743,"domainLookupStart":305.90000009536743,"fetchStart":305.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":431.2999997138977,"responseEnd":1330.2999997138977,"responseStart":1176.5999999046326,"secureConnectionStart":305.90000009536743},{"duration":1213.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":306.09999990463257,"connectEnd":306.09999990463257,"connectStart":306.09999990463257,"domainLookupEnd":306.09999990463257,"domainLookupStart":306.09999990463257,"fetchStart":306.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":431.5,"responseEnd":1519.6999998092651,"responseStart":1177.6999998092651,"secureConnectionStart":306.09999990463257},{"duration":866.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":306.40000009536743,"connectEnd":306.40000009536743,"connectStart":306.40000009536743,"domainLookupEnd":306.40000009536743,"domainLookupStart":306.40000009536743,"fetchStart":306.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":431.59999990463257,"responseEnd":1172.5999999046326,"responseStart":1172,"secureConnectionStart":306.40000009536743},{"duration":853.9000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":306.59999990463257,"connectEnd":306.59999990463257,"connectStart":306.59999990463257,"domainLookupEnd":306.59999990463257,"domainLookupStart":306.59999990463257,"fetchStart":306.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":431.69999980926514,"responseEnd":1160.5,"responseStart":1160,"secureConnectionStart":306.59999990463257},{"duration":865,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":306.90000009536743,"connectEnd":306.90000009536743,"connectStart":306.90000009536743,"domainLookupEnd":306.90000009536743,"domainLookupStart":306.90000009536743,"fetchStart":306.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":431.7999997138977,"responseEnd":1171.9000000953674,"responseStart":1160.7999997138977,"secureConnectionStart":306.90000009536743},{"duration":116.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":307.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":307.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":423.2999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":377.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":307.2999997138977,"connectEnd":425.69999980926514,"connectStart":425.69999980926514,"domainLookupEnd":425.69999980926514,"domainLookupStart":425.69999980926514,"fetchStart":307.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":432.59999990463257,"responseEnd":685.0999999046326,"responseStart":527.5,"secureConnectionStart":425.69999980926514},{"duration":118.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":307.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":307.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":425.5,"responseStart":0,"secureConnectionStart":0},{"duration":413.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":307.59999990463257,"connectEnd":307.59999990463257,"connectStart":307.59999990463257,"domainLookupEnd":307.59999990463257,"domainLookupStart":307.59999990463257,"fetchStart":307.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":432.7999997138977,"responseEnd":721.4000000953674,"responseStart":622.6999998092651,"secureConnectionStart":307.59999990463257},{"duration":1626.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":308.5,"connectEnd":308.5,"connectStart":308.5,"domainLookupEnd":308.5,"domainLookupStart":308.5,"fetchStart":308.5,"redirectEnd":0,"redirectStart":0,"requestStart":497.59999990463257,"responseEnd":1935.0999999046326,"responseStart":1923.6999998092651,"secureConnectionStart":308.5},{"duration":1628.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":308.59999990463257,"connectEnd":308.59999990463257,"connectStart":308.59999990463257,"domainLookupEnd":308.59999990463257,"domainLookupStart":308.59999990463257,"fetchStart":308.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":720.1999998092651,"responseEnd":1936.6999998092651,"responseStart":1926.1999998092651,"secureConnectionStart":308.59999990463257},{"duration":244.69999980926514,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1504.9000000953674,"connectEnd":1504.9000000953674,"connectStart":1504.9000000953674,"domainLookupEnd":1504.9000000953674,"domainLookupStart":1504.9000000953674,"fetchStart":1504.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":1691.5999999046326,"responseEnd":1749.5999999046326,"responseStart":1735,"secureConnectionStart":1504.9000000953674}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":29,"responseStart":236,"responseEnd":305,"domLoading":254,"domInteractive":2051,"domContentLoadedEventStart":2051,"domContentLoadedEventEnd":2100,"domComplete":3535,"loadEventStart":3535,"loadEventEnd":3536,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2025.4000000953674},{"name":"bigPipe.sidebar-id.end","time":2026.5999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":2026.7999997138977},{"name":"bigPipe.activity-panel-pipe-id.end","time":2027.6999998092651},{"name":"activityTabFullyLoaded","time":2120}],"measures":[],"correlationId":"22f3d1912313fd","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":92,"dbReadsTimeInMs":13,"dbConnsTimeInMs":22,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}