Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19955

make argument of handler::ha_write_row() const

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.5, 10.1, 10.2, 10.3, 10.4, 10.5
    • Fix Version/s: 10.4.7
    • Component/s: Server
    • Labels:
      None

      Description

      int handler::ha_write_row(uchar * buf);
      This interface clearly states that storage engine is allowed to modify memory where buf points.

      It was used in native InnoDB system versioned tables and I fixed two bugs on that topic. One is MDEV-19486 and another one is not mentioned in Jira.

      Actually, calling code for `handler::ha_write_row()` is not prepared to buffer change by engine. I see not places in the code where it's used now. Thus I see no reason on having a mutable argument here.

      I'll make it const to prevent future bugs.

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-19486 Server crashes in row_upd or row_upd_del_mark_clust_rec on REPLACE into a versioned table

          • Major - Major loss of function.
          • Closed

            Activity

              People

              • Assignee:
                kevg Eugene Kosov
                Reporter:
                kevg Eugene Kosov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: