Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
5.5(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL), 10.4(EOL), 10.5
-
None
Description
int handler::ha_write_row(uchar * buf);
This interface clearly states that storage engine is allowed to modify memory where buf points.
It was used in native InnoDB system versioned tables and I fixed two bugs on that topic. One is MDEV-19486 and another one is not mentioned in Jira.
Actually, calling code for `handler::ha_write_row()` is not prepared to buffer change by engine. I see not places in the code where it's used now. Thus I see no reason on having a mutable argument here.
I'll make it const to prevent future bugs.
Attachments
Issue Links
- relates to
-
MDEV-19486 Server crashes in row_upd or row_upd_del_mark_clust_rec on REPLACE into a versioned table
-
- Closed
-
Activity
Field | Original Value | New Value |
---|---|---|
Link |
This issue relates to |
Rank | Ranked higher |
Fix Version/s | 10.4.7 [ 23720 ] | |
Fix Version/s | 10.4 [ 22408 ] | |
Fix Version/s | 10.5 [ 23123 ] | |
Resolution | Fixed [ 1 ] | |
Status | Open [ 1 ] | Closed [ 6 ] |
Workflow | MariaDB v3 [ 98021 ] | MariaDB v4 [ 156438 ] |