Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19929

Add a startup message about PAUSE instruction timing

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 10.3, 10.4
    • Fix Version/s: 10.3, 10.4
    • Component/s: Server
    • Labels:
      None

      Description

      It would be useful to log the outcome of the startup check that was implemented as part of MDEV-19845.

      The following patch technically works and does not cause an extra message to the log that is displayed by mysql-test-run.pl startup, but it is not nice in that it is scattering the logic to two source code modules:

      diff --git a/sql/mysqld.cc b/sql/mysqld.cc
      index f98f51c73d0..5b439856e84 100644
      --- a/sql/mysqld.cc
      +++ b/sql/mysqld.cc
      @@ -6198,6 +6198,10 @@ int mysqld_main(int argc, char **argv)
                                 mysqld_port, MYSQL_COMPILATION_COMMENT);
         }
       
      +#ifdef HAVE_PAUSE_INSTRUCTION
      +  sql_print_information("Using PAUSE multiplier %u", my_cpu_relax_multiplier);
      +#endif
      +
       #ifndef _WIN32
         // try to keep fd=0 busy
         if (please_close_stdin && !freopen("/dev/null", "r", stdin))
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              svoj Sergey Vojtovich
              Reporter:
              marko Marko Mäkelä
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated: