Details
-
Bug
-
Status: In Review (View Workflow)
-
Major
-
Resolution: Unresolved
-
10.3(EOL), 10.4(EOL), 10.5
-
None
Description
It would be useful to log the outcome of the startup check that was implemented as part of MDEV-19845.
The following patch technically works and does not cause an extra message to the log that is displayed by mysql-test-run.pl startup, but it is not nice in that it is scattering the logic to two source code modules:
diff --git a/sql/mysqld.cc b/sql/mysqld.cc
|
index f98f51c73d0..5b439856e84 100644
|
--- a/sql/mysqld.cc
|
+++ b/sql/mysqld.cc
|
@@ -6198,6 +6198,10 @@ int mysqld_main(int argc, char **argv)
|
mysqld_port, MYSQL_COMPILATION_COMMENT);
|
}
|
|
+#ifdef HAVE_PAUSE_INSTRUCTION
|
+ sql_print_information("Using PAUSE multiplier %u", my_cpu_relax_multiplier);
|
+#endif
|
+
|
#ifndef _WIN32
|
// try to keep fd=0 busy
|
if (please_close_stdin && !freopen("/dev/null", "r", stdin)) |
Attachments
Issue Links
- is blocked by
-
MDEV-22871 Contention on the buf_pool.page_hash
-
- Closed
-
- relates to
-
MDEV-19845 Adaptive spin loops
-
- Closed
-
-
MDEV-22850 Reduce buf_pool.page_hash latch contention
-
- Closed
-
We can't use defines for having pause as there is no guarantee that the computer we run the program has the same CPU as the one where we compiled.
Any detection of cpu instructions and the usage of them has to be done runtime