Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19846

mariadb-10.4.6/plugin/auth_pam/auth_pam.c:104]: (style) Suspicious condition

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.4
    • Fix Version/s: 10.4.7
    • Component/s: Plugin - pam
    • Labels:
      None

      Description

      mariadb-10.4.6/plugin/auth_pam/auth_pam.c:104]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

      Source code is

      if ((pkt_len= vio->read_packet(vio, &pkt) < 0))

      Maybe better code:

      if ((pkt_len = vio->read_packet(vio, &pkt)) < 0)

        Attachments

          Activity

            People

            Assignee:
            serg Sergei Golubchik
            Reporter:
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: