Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19801

Change defaults for CHANGE MASTER TO so that GTID-based replication is used by default if master supports it

Details

    Description

      It is known (see https://mariadb.com/kb/en/library/gtid/) that GTID-based replication in MariaDB is the only potentially crash-safe way to replicate. So, it would make sense to use it by default as long as master supports GTIDs (version is 10.0.2+).

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28798 Previously Binlog Encrypted Master Segfaults on Binlog Dump with Using_Gtid=Slave_Pos

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bnestere Brandon Nesterenko added a comment -

            Hi Andrei! This is ready for review.

            There are two relevant commits on the branch bb-10.10-MDEV-19801

            Commit 1 contains the code changes with an MTR test specific to the code changes: 723c1d3
            Commit 2 contains the changes to the MTR tests 19e54ac

            Buildbot: bb-10.10-MDEV-19801

            bnestere Brandon Nesterenko added a comment - Hi Andrei! This is ready for review. There are two relevant commits on the branch bb-10.10-MDEV-19801 Commit 1 contains the code changes with an MTR test specific to the code changes: 723c1d3 Commit 2 contains the changes to the MTR tests 19e54ac Buildbot: bb-10.10-MDEV-19801
            Elkin Andrei Elkin added a comment -

            Thanks for this work which is approved, provided a new mtr test macro to be introduced later.

            Elkin Andrei Elkin added a comment - Thanks for this work which is approved, provided a new mtr test macro to be introduced later.
            bnestere Brandon Nesterenko added a comment - - edited

            Hi angelique.sklavounos!

            I am re-assigning this to you for testing. The preview branch is preview-10.10-gtid.

            Please let me know if you have any questions.

            bnestere Brandon Nesterenko added a comment - - edited Hi angelique.sklavounos ! I am re-assigning this to you for testing. The preview branch is preview-10.10-gtid . Please let me know if you have any questions.
            angelique.sklavounos Angelique Sklavounos (Inactive) added a comment -

            OK to push.

            angelique.sklavounos Angelique Sklavounos (Inactive) added a comment - OK to push.
            bnestere Brandon Nesterenko added a comment -

            Howdy Andrei!

            This is ready for a final round of review before pushing into 10.10

            https://github.com/MariaDB/server/pull/2151

            bnestere Brandon Nesterenko added a comment - Howdy Andrei! This is ready for a final round of review before pushing into 10.10 https://github.com/MariaDB/server/pull/2151
            Elkin Andrei Elkin added a comment -

            Approved on GH.

            Elkin Andrei Elkin added a comment - Approved on GH.

            People

              bnestere Brandon Nesterenko
              valerii Valerii Kravchuk
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.