-
Task
-
-
Major
-
Resolution:
Fixed
-
-
-
This code in sql_table.cc is not friendly to data type plugins:
if ((sql_field->real_field_type() != MYSQL_TYPE_STRING &&
|
sql_field->real_field_type() != MYSQL_TYPE_VARCHAR &&
|
!f_is_blob(sql_field->pack_flag)) ||
|
sql_field->charset == &my_charset_bin ||
|
sql_field->charset->mbminlen > 1 || // ucs2 doesn't work yet
|
(ft_key_charset && sql_field->charset != ft_key_charset))
|
{
|
my_error(ER_BAD_FT_COLUMN, MYF(0), column->field_name.str);
|
DBUG_RETURN(-1);
|
}
|
ft_key_charset=sql_field->charset;
|
/*
|
for fulltext keys keyseg length is 1 for blobs (it's ignored in ft
|
code anyway, and 0 (set to column width later) for char's. it has
|
to be correct col width for char's, as char data are not prefixed
|
with length (unlike blobs, where ft code takes data length from a
|
data prefix, ignoring column->length).
|
*/
|
column->length= MY_TEST(f_is_blob(sql_field->pack_flag));
|
New data types will reuse the same type codes. For example, INET6 will report itself as MYSQL_TYPE_STRING while it won't support fulltext.
Let's add a new method in Type_handler:
virtual bool Key_part_spec_init_ft(Key_part_spec *part,
|
const Column_definition &def) const;
|
and split this code into virtual implementations for specific Type_handler_xxx implementations.
- blocks
-
MDEV-4912
Data type plugin API version 1
-
-
Closed
Alexander Barkov
made changes -
Status
|
Open
[ 1
]
|
In Progress
[ 3
]
|
Alexander Barkov
made changes -
issue.field.resolutiondate
|
2019-06-11 07:11:12.0
|
2019-06-11 07:11:12.046
|
Alexander Barkov
made changes -
Fix Version/s
|
|
10.5.0
[ 23709
]
|
Fix Version/s
|
10.5
[ 23123
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
Status
|
In Progress
[ 3
]
|
Closed
[ 6
]
|
Sergei Golubchik
made changes -
Workflow
|
MariaDB v3
[ 97450
]
|
MariaDB v4
[ 133990
]
|
{"report":{"fcp":1262.6999998092651,"ttfb":537.1999998092651,"pageVisibility":"visible","entityId":76736,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"8032c4d5-3dd9-4b0e-adbf-590b1f6c352f","navigationType":0,"readyForUser":1328.5,"redirectCount":0,"resourceLoadedEnd":1312.6999998092651,"resourceLoadedStart":543.5,"resourceTiming":[{"duration":267.2999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":543.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":543.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":810.7999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":267.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":543.6999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":543.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":811.0999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":276.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":543.8999996185303,"connectEnd":543.8999996185303,"connectStart":543.8999996185303,"domainLookupEnd":543.8999996185303,"domainLookupStart":543.8999996185303,"fetchStart":543.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":543.8999996185303,"responseEnd":820.7999997138977,"responseStart":820.6999998092651,"secureConnectionStart":543.8999996185303},{"duration":302.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":544.0999999046326,"connectEnd":544.0999999046326,"connectStart":544.0999999046326,"domainLookupEnd":544.0999999046326,"domainLookupStart":544.0999999046326,"fetchStart":544.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":544.0999999046326,"responseEnd":846.1999998092651,"responseStart":846.1999998092651,"secureConnectionStart":544.0999999046326},{"duration":305.7000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":544.2999997138977,"connectEnd":544.2999997138977,"connectStart":544.2999997138977,"domainLookupEnd":544.2999997138977,"domainLookupStart":544.2999997138977,"fetchStart":544.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":544.2999997138977,"responseEnd":850,"responseStart":850,"secureConnectionStart":544.2999997138977},{"duration":305.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":544.5999999046326,"connectEnd":544.5999999046326,"connectStart":544.5999999046326,"domainLookupEnd":544.5999999046326,"domainLookupStart":544.5999999046326,"fetchStart":544.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":544.5999999046326,"responseEnd":850.3999996185303,"responseStart":850.3999996185303,"secureConnectionStart":544.5999999046326},{"duration":306.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":544.5999999046326,"connectEnd":544.5999999046326,"connectStart":544.5999999046326,"domainLookupEnd":544.5999999046326,"domainLookupStart":544.5999999046326,"fetchStart":544.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":544.5999999046326,"responseEnd":850.6999998092651,"responseStart":850.6999998092651,"secureConnectionStart":544.5999999046326},{"duration":306.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":544.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":544.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":851.6999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":306.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":545,"connectEnd":545,"connectStart":545,"domainLookupEnd":545,"domainLookupStart":545,"fetchStart":545,"redirectEnd":0,"redirectStart":0,"requestStart":545,"responseEnd":851.2999997138977,"responseStart":851.2999997138977,"secureConnectionStart":545},{"duration":306.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":545.1999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":545.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":852.0999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":306.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":545.2999997138977,"connectEnd":545.2999997138977,"connectStart":545.2999997138977,"domainLookupEnd":545.2999997138977,"domainLookupStart":545.2999997138977,"fetchStart":545.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":545.2999997138977,"responseEnd":851.6999998092651,"responseStart":851.6999998092651,"secureConnectionStart":545.2999997138977},{"duration":721.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":546.2999997138977,"connectEnd":546.2999997138977,"connectStart":546.2999997138977,"domainLookupEnd":546.2999997138977,"domainLookupStart":546.2999997138977,"fetchStart":546.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":546.2999997138977,"responseEnd":1267.8999996185303,"responseStart":1267.8999996185303,"secureConnectionStart":546.2999997138977},{"duration":766.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":546.2999997138977,"connectEnd":546.2999997138977,"connectStart":546.2999997138977,"domainLookupEnd":546.2999997138977,"domainLookupStart":546.2999997138977,"fetchStart":546.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":546.2999997138977,"responseEnd":1312.6999998092651,"responseStart":1312.6999998092651,"secureConnectionStart":546.2999997138977},{"duration":260.59999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1041,"connectEnd":1041,"connectStart":1041,"domainLookupEnd":1041,"domainLookupStart":1041,"fetchStart":1041,"redirectEnd":0,"redirectStart":0,"requestStart":1041,"responseEnd":1301.5999999046326,"responseStart":1301.5999999046326,"secureConnectionStart":1041},{"duration":201,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1226.0999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1226.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1427.0999999046326,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":66,"responseStart":537,"responseEnd":541,"domLoading":541,"domInteractive":1461,"domContentLoadedEventStart":1461,"domContentLoadedEventEnd":1499,"domComplete":1763,"loadEventStart":1763,"loadEventEnd":1764,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1435.5999999046326},{"name":"bigPipe.sidebar-id.end","time":1436.5},{"name":"bigPipe.activity-panel-pipe-id.start","time":1436.6999998092651},{"name":"bigPipe.activity-panel-pipe-id.end","time":1439.0999999046326},{"name":"activityTabFullyLoaded","time":1513.5}],"measures":[],"correlationId":"e3596419903986","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":111,"dbReadsTimeInMs":16,"dbConnsTimeInMs":24,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}