Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19679

CREATE SERVER needs tweaks for compatibility with CONNECT engine

Details

    Description

      The CREATE SERVER command needs to be tweaked to provide better compatibility with CONNECT engine. It can be accomplished as follows:

      #1
      Extend the length of the mysql.servers.Host column to 2048 chars (to support CONNECT engine's use of this column for the host connection URL which can easily run to 500 or even 1,000+ chars with certain sets of connection properties)

      #2
      Extend the length of the mysql.servers.Owner column to 512 chars (to support CONNECT engine's use of this column for storing multiple additional connection options)

      #3
      Fix the forced lower casing of the host column - right now create server forces the host data to lower case, which is incorrect when storing a host connection URL for connect engine that may contain case sensitive parameters such as passwords and security tokens.

      This issue is related to MDEV-13136 which solved part of the problem but requires the above fixes to work properly.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-726 LP:1002807 - CREATE SERVER still not converting hostnames to lower case

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 10 older comments
            rdyas Robert Dyas added a comment -

            Any additional info on this?

            rdyas Robert Dyas added a comment - Any additional info on this?
            serg Sergei Golubchik added a comment -

            hholzgra, what was the point in MDEV-726? Can there be grants on host names in CREATE SERVER?
            Why should CREATE SERVER follow GRANT rules?

            serg Sergei Golubchik added a comment - hholzgra , what was the point in MDEV-726 ? Can there be grants on host names in CREATE SERVER ? Why should CREATE SERVER follow GRANT rules?
            hholzgra Hartmut Holzgraefe added a comment -

            I'm trying to remember ... I was probably thinking along the lines of "DNS host names are case insensitive, so they should be stored in that way over here, too".

            There might have been a support issue related to this, but back then we didn't have a support issue filed in Jira yet, and Eventum search does not turn anything up either.

            As far as I can tell back then in 2012 this was only used by FEDERATED and FEDERATEDX, so the assumption that the `host` column only stores IP addresses or DNS seemed to make sense at that point.

            hholzgra Hartmut Holzgraefe added a comment - I'm trying to remember ... I was probably thinking along the lines of "DNS host names are case insensitive, so they should be stored in that way over here, too". There might have been a support issue related to this, but back then we didn't have a support issue filed in Jira yet, and Eventum search does not turn anything up either. As far as I can tell back then in 2012 this was only used by FEDERATED and FEDERATEDX, so the assumption that the `host` column only stores IP addresses or DNS seemed to make sense at that point.
            serg Sergei Golubchik added a comment -

            ok to push

            serg Sergei Golubchik added a comment - ok to push
            anel Anel Husakovic added a comment -

            Pushed with 1ad79c818780aafe.

            anel Anel Husakovic added a comment - Pushed with 1ad79c818780aafe .

            People

              anel Anel Husakovic
              rdyas Robert Dyas
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.