Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19638

GCC compiler warnings

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 10.4.5
    • 10.5.0
    • Compiling
    • None
    • GCC8

    Description

      Hello,

      GCC generates warnings about many different problems:
      E.g.

      • truncated output
      • misleading indentation
      • unsed variables
      • dangling else
      • unused functions
      • differences between pointer signedness
      • Weirdly constructed for loop headers. E.g. for (i = 0, pcrp = &qrp->Colresp; crp = *pcrp; )

      I attached the output of GCC on stderr.

      Please let me know if and how you want to handle that. Some warnings like the dangling else and misleading indentation can be the cause of bugs or problems with debugging later. Truncated output is only mildly concerning.

      On a side note, I put together a rather large patch set that changes the handling of the cflags and cxxflags in the CMake configuration files to make sure invalid options for the compiler aren't passed. E.g. GCC exclusive options passed to G++ and vice versa.

      Kind regards

      Noel Kuntze

      Attachments

        Activity

          People

            robertbindar Robert Bindar
            thermi Noel Kuntze
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.