Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19621

Server crashes in ha_innobase::commit_inplace_alter_table upon dropping virtual column

    XMLWordPrintable

    Details

      Description

      Note: It can be a duplicate of anything. I've lost count of virtual column-related bugs, and the stack trace is non-specific.

      --source include/have_innodb.inc
       
      CREATE TABLE t1 (a INT, b INT, c INT AS (b), KEY(b)) ENGINE=InnoDB;
      ALTER TABLE t1 ADD FOREIGN KEY (a) REFERENCES t1 (b);
      ALTER TABLE t1 ADD KEY idx (a);
      SET FOREIGN_KEY_CHECKS = OFF ;
      ALTER TABLE t1 DROP KEY idx;
      ALTER TABLE t1 DROP COLUMN c;
       
      # Cleanup
      DROP TABLE t1;
      

      10.2 bff9b802

      2019-05-28 16:57:09 140003140097792 [Warning] InnoDB: Load table `test`.`t1` failed, the table has missing foreign key indexes. Turn off 'foreign_key_checks' and try again.
       
      #3  <signal handler called>
      #4  0x000055cf7c901f5d in ha_innobase::commit_inplace_alter_table (this=0x7f54ac082c88, altered_table=0x7f54ac03cb40, ha_alter_info=0x7f55056e9c60, commit=true) at /data/src/10.2/storage/innobase/handler/handler0alter.cc:8677
      #5  0x000055cf7c6bd0bb in handler::ha_commit_inplace_alter_table (this=0x7f54ac082c88, altered_table=0x7f54ac03cb40, ha_alter_info=0x7f55056e9c60, commit=true) at /data/src/10.2/sql/handler.cc:4325
      #6  0x000055cf7c50975d in mysql_inplace_alter_table (thd=0x7f54ac000b00, table_list=0x7f54ac012330, table=0x7f54ac082080, altered_table=0x7f54ac03cb40, ha_alter_info=0x7f55056e9c60, inplace_supported=HA_ALTER_INPLACE_NO_LOCK_AFTER_PREPARE, target_mdl_request=0x7f55056e9cf0, alter_ctx=0x7f55056ea2a0) at /data/src/10.2/sql/sql_table.cc:7388
      #7  0x000055cf7c50f152 in mysql_alter_table (thd=0x7f54ac000b00, new_db=0x7f54ac012940 "test", new_name=0x0, create_info=0x7f55056eaeb0, table_list=0x7f54ac012330, alter_info=0x7f55056eae00, order_num=0, order=0x0, ignore=false) at /data/src/10.2/sql/sql_table.cc:9489
      #8  0x000055cf7c589e7f in Sql_cmd_alter_table::execute (this=0x7f54ac012970, thd=0x7f54ac000b00) at /data/src/10.2/sql/sql_alter.cc:321
      #9  0x000055cf7c440b96 in mysql_execute_command (thd=0x7f54ac000b00) at /data/src/10.2/sql/sql_parse.cc:6233
      #10 0x000055cf7c445cba in mysql_parse (thd=0x7f54ac000b00, rawbuf=0x7f54ac012248 "ALTER TABLE t1 DROP COLUMN c", length=28, parser_state=0x7f55056ec250, is_com_multi=false, is_next_command=false) at /data/src/10.2/sql/sql_parse.cc:8020
      #11 0x000055cf7c43350e in dispatch_command (command=COM_QUERY, thd=0x7f54ac000b00, packet=0x7f54ac066eb1 "ALTER TABLE t1 DROP COLUMN c", packet_length=28, is_com_multi=false, is_next_command=false) at /data/src/10.2/sql/sql_parse.cc:1833
      #12 0x000055cf7c431e62 in do_command (thd=0x7f54ac000b00) at /data/src/10.2/sql/sql_parse.cc:1386
      #13 0x000055cf7c584b38 in do_handle_one_connection (connect=0x55cf7fae80f0) at /data/src/10.2/sql/sql_connect.cc:1335
      #14 0x000055cf7c5848b8 in handle_one_connection (arg=0x55cf7fae80f0) at /data/src/10.2/sql/sql_connect.cc:1241
      #15 0x00007f5509b054a4 in start_thread (arg=0x7f55056ed700) at pthread_create.c:456
      #16 0x00007f550804dd0f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:97
      

      All of debug, ASAN and non-debug builds fail with SEGV.
      Not reproducible on 10.1.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              thiru Thirunarayanan Balathandayuthapani
              Reporter:
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Git Integration