Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19388

Improve SSD detection in fil_node_t::get_metadata on Windows

    Details

      Description

      Currently, for SSD detection on Windows, innodb uses DeviceIOControl with IOCTL_STORAGE_QUERY_PROPERTY/StorageDeviceSeekPenaltyProperty . On multiple machines, especially in cloud, it would fail (not implemented, or other reason).

      However, SSD can be detected with other means, e.g if TRIM is enabled (s. https://stackoverflow.com/questions/23363115/detecting-ssd-in-windows) . Support for this in DeviceIoControl is better, at least Azure machines correctly return the value.

      We should call DeviceIOControl w.IOCTL_STORAGE_QUERY_PROPERTY with StorageDeviceSeekPenaltyProperty first, then fallback to StorageDeviceTrimProperty, and if both fails, decide it is ultimately not SSD.

        Attachments

          Activity

            People

            • Assignee:
              wlad Vladislav Vaintroub
              Reporter:
              wlad Vladislav Vaintroub
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: