Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19256

sql_acl.cc does not compile with WITH_VALGRIND with gcc 8.0

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.4(EOL)
    • 10.4.5
    • OTHER
    • None

    Description

      Class Sql_alloc has a constructor when HAVE_valgrind is enabled:

      class Sql_alloc
      		 
      {
      		 
      public:
      		 
       ...
      		 
      #ifdef HAVE_valgrind
      		 
        bool dummy_for_valgrind;
      		 
        inline Sql_alloc() :dummy_for_valgrind(0) {}
      		 
      #endif
      		 
      };

      so gcc-8.0 does not like when bzero is done over Sql_alloc descendants.

      sql_acl.cc has some such classes:

      • ACL_ACCESS
      • ACL_USER_BASE
      • ACL_USER
        that derive from Sql_alloc and are used with bzero.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          bar Alexander Barkov created issue -
          bar Alexander Barkov made changes -
          Field Original Value New Value
          Rank Ranked higher
          bar Alexander Barkov made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          bar Alexander Barkov made changes -
          issue.field.resolutiondate 2019-04-16 05:55:03.0 2019-04-16 05:55:03.558
          bar Alexander Barkov made changes -
          Component/s OTHER [ 10125 ]
          Fix Version/s 10.4.5 [ 23311 ]
          Fix Version/s 10.4 [ 22408 ]
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 95394 ] MariaDB v4 [ 156075 ]

          People

            bar Alexander Barkov
            bar Alexander Barkov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.