Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-19256

sql_acl.cc does not compile with WITH_VALGRIND with gcc 8.0

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 10.4
    • Fix Version/s: 10.4.5
    • Component/s: OTHER
    • Labels:
      None

      Description

      Class Sql_alloc has a constructor when HAVE_valgrind is enabled:

      class Sql_alloc
      {
      public:
       ...
      #ifdef HAVE_valgrind
        bool dummy_for_valgrind;
        inline Sql_alloc() :dummy_for_valgrind(0) {}
      #endif
      };
      

      so gcc-8.0 does not like when bzero is done over Sql_alloc descendants.

      sql_acl.cc has some such classes:

      • ACL_ACCESS
      • ACL_USER_BASE
      • ACL_USER
        that derive from Sql_alloc and are used with bzero.

        Attachments

          Activity

            People

            • Assignee:
              bar Alexander Barkov
              Reporter:
              bar Alexander Barkov
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: