Details

    Description

      This will make code like if ( err == DB_SUCCESS) work a bit faster because CPUs have instructions to check for zero fast.

      Attachments

        Issue Links

          Activity

            This cleanup revealed that a few calls to os_file_read() in MariaDB and Mariabackup 10.2 had not been adjusted to the change of the return type from Boolean to dberr_t. In 10.3, also some calls to os_file_write() were incorrect. This means that errors from these calls were being effectively ignored. That was fixed as part of applying the cleanup.

            marko Marko Mäkelä added a comment - This cleanup revealed that a few calls to os_file_read() in MariaDB and Mariabackup 10.2 had not been adjusted to the change of the return type from Boolean to dberr_t . In 10.3, also some calls to os_file_write() were incorrect. This means that errors from these calls were being effectively ignored. That was fixed as part of applying the cleanup.

            In 10.4, MDEV-12026 introduced one more misuse of os_file_read() in mariabackup’s xb_assign_undo_space_start(). That was caught in the merge.

            marko Marko Mäkelä added a comment - In 10.4, MDEV-12026 introduced one more misuse of os_file_read() in mariabackup ’s xb_assign_undo_space_start() . That was caught in the merge.

            People

              kevg Eugene Kosov (Inactive)
              kevg Eugene Kosov (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.