Type:
Task
Priority:
Major
Resolution:
Fixed
Speed up rotation of binary logs when there are 10,000 logs
The problem is that find_uniq_filename() for each creating of a new binary log file reads all files from the directory, which can take a long time if there are a lot of binary log files.
Fix is to cache the last used log name number and reuse that for future calls.
is duplicated by
MDEV-18614
Optimization for binlog rotation
Closed
{"report":{"fcp":826.5,"ttfb":274.19999980926514,"pageVisibility":"visible","entityId":74129,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"ffbb5ca1-f657-4e6a-acb7-4a04e017b380","navigationType":0,"readyForUser":888,"redirectCount":0,"resourceLoadedEnd":675.4000000953674,"resourceLoadedStart":282,"resourceTiming":[{"duration":49.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":282,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":282,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":331.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":49.299999713897705,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":282.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":282.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":331.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":91.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":282.40000009536743,"connectEnd":282.40000009536743,"connectStart":282.40000009536743,"domainLookupEnd":282.40000009536743,"domainLookupStart":282.40000009536743,"fetchStart":282.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":334.5,"responseEnd":373.5,"responseStart":346.59999990463257,"secureConnectionStart":282.40000009536743},{"duration":104.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":282.69999980926514,"connectEnd":282.69999980926514,"connectStart":282.69999980926514,"domainLookupEnd":282.69999980926514,"domainLookupStart":282.69999980926514,"fetchStart":282.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":336.19999980926514,"responseEnd":387.59999990463257,"responseStart":350.30000019073486,"secureConnectionStart":282.69999980926514},{"duration":76.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":282.90000009536743,"connectEnd":282.90000009536743,"connectStart":282.90000009536743,"domainLookupEnd":282.90000009536743,"domainLookupStart":282.90000009536743,"fetchStart":282.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":337.80000019073486,"responseEnd":359.19999980926514,"responseStart":358.19999980926514,"secureConnectionStart":282.90000009536743},{"duration":77,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":283.09999990463257,"connectEnd":283.09999990463257,"connectStart":283.09999990463257,"domainLookupEnd":283.09999990463257,"domainLookupStart":283.09999990463257,"fetchStart":283.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":338,"responseEnd":360.09999990463257,"responseStart":359.30000019073486,"secureConnectionStart":283.09999990463257},{"duration":79.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":283.30000019073486,"connectEnd":283.30000019073486,"connectStart":283.30000019073486,"domainLookupEnd":283.30000019073486,"domainLookupStart":283.30000019073486,"fetchStart":283.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":339.19999980926514,"responseEnd":363,"responseStart":362.09999990463257,"secureConnectionStart":283.30000019073486},{"duration":54.59999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":283.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":283.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":338,"responseStart":0,"secureConnectionStart":0},{"duration":83.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":283.5,"connectEnd":283.5,"connectStart":283.5,"domainLookupEnd":283.5,"domainLookupStart":283.5,"fetchStart":283.5,"redirectEnd":0,"redirectStart":0,"requestStart":342.19999980926514,"responseEnd":366.69999980926514,"responseStart":365.80000019073486,"secureConnectionStart":283.5},{"duration":55.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":283.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":283.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":339.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":81.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":283.80000019073486,"connectEnd":283.80000019073486,"connectStart":283.80000019073486,"domainLookupEnd":283.80000019073486,"domainLookupStart":283.80000019073486,"fetchStart":283.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":342.30000019073486,"responseEnd":365.59999990463257,"responseStart":364.40000009536743,"secureConnectionStart":283.80000019073486},{"duration":377.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":290.19999980926514,"connectEnd":290.19999980926514,"connectStart":290.19999980926514,"domainLookupEnd":290.19999980926514,"domainLookupStart":290.19999980926514,"fetchStart":290.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":491.69999980926514,"responseEnd":667.6999998092651,"responseStart":664.1999998092651,"secureConnectionStart":290.19999980926514},{"duration":385.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":290.30000019073486,"connectEnd":290.30000019073486,"connectStart":290.30000019073486,"domainLookupEnd":290.30000019073486,"domainLookupStart":290.30000019073486,"fetchStart":290.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":605.3000001907349,"responseEnd":675.4000000953674,"responseStart":671.0999999046326,"secureConnectionStart":290.30000019073486},{"duration":193.09999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":575.8000001907349,"connectEnd":575.8000001907349,"connectStart":575.8000001907349,"domainLookupEnd":575.8000001907349,"domainLookupStart":575.8000001907349,"fetchStart":575.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":734.3000001907349,"responseEnd":768.9000000953674,"responseStart":767.9000000953674,"secureConnectionStart":575.8000001907349},{"duration":111.09999990463257,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":807.3000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":807.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":918.4000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":143.09999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":829.0999999046326,"connectEnd":829.0999999046326,"connectStart":829.0999999046326,"domainLookupEnd":829.0999999046326,"domainLookupStart":829.0999999046326,"fetchStart":829.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":931.1999998092651,"responseEnd":972.1999998092651,"responseStart":971.1999998092651,"secureConnectionStart":829.0999999046326}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":118,"responseStart":274,"responseEnd":289,"domLoading":278,"domInteractive":941,"domContentLoadedEventStart":941,"domContentLoadedEventEnd":982,"domComplete":1561,"loadEventStart":1561,"loadEventEnd":1568,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":920.4000000953674},{"name":"bigPipe.sidebar-id.end","time":921.1999998092651},{"name":"bigPipe.activity-panel-pipe-id.start","time":921.5},{"name":"bigPipe.activity-panel-pipe-id.end","time":922.3000001907349},{"name":"activityTabFullyLoaded","time":997.5999999046326}],"measures":[],"correlationId":"c22eff3e2e5a1a","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":100,"dbReadsTimeInMs":16,"dbConnsTimeInMs":28,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Pushed