Type:
Task
Priority:
Major
Resolution:
Fixed
Speed up rotation of binary logs when there are 10,000 logs
The problem is that find_uniq_filename() for each creating of a new binary log file reads all files from the directory, which can take a long time if there are a lot of binary log files.
Fix is to cache the last used log name number and reuse that for future calls.
is duplicated by
MDEV-18614
Optimization for binlog rotation
Closed
{"report":{"fcp":1172.5,"ttfb":198.69999980926514,"pageVisibility":"visible","entityId":74129,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":32,"apdex":0.5,"journeyId":"0ff6cfe3-5697-47c9-8dea-9bce367e2da0","navigationType":0,"readyForUser":1255.6999998092651,"redirectCount":0,"resourceLoadedEnd":899.5,"resourceLoadedStart":204.69999980926514,"resourceTiming":[{"duration":30.600000381469727,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":204.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":204.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":235.30000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":30.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":205,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":205,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":235.5,"responseStart":0,"secureConnectionStart":0},{"duration":390.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":205.19999980926514,"connectEnd":205.19999980926514,"connectStart":205.19999980926514,"domainLookupEnd":205.19999980926514,"domainLookupStart":205.19999980926514,"fetchStart":205.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":248.59999990463257,"responseEnd":595.5999999046326,"responseStart":301.19999980926514,"secureConnectionStart":205.19999980926514},{"duration":422.7999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":205.30000019073486,"connectEnd":205.30000019073486,"connectStart":205.30000019073486,"domainLookupEnd":205.30000019073486,"domainLookupStart":205.30000019073486,"fetchStart":205.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":237.90000009536743,"responseEnd":628.0999999046326,"responseStart":282.09999990463257,"secureConnectionStart":205.30000019073486},{"duration":76.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":205.59999990463257,"connectEnd":205.59999990463257,"connectStart":205.59999990463257,"domainLookupEnd":205.59999990463257,"domainLookupStart":205.59999990463257,"fetchStart":205.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":251.09999990463257,"responseEnd":282,"responseStart":281.19999980926514,"secureConnectionStart":205.59999990463257},{"duration":207.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":205.80000019073486,"connectEnd":205.80000019073486,"connectStart":205.80000019073486,"domainLookupEnd":205.80000019073486,"domainLookupStart":205.80000019073486,"fetchStart":205.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":252.59999990463257,"responseEnd":413.5,"responseStart":412.30000019073486,"secureConnectionStart":205.80000019073486},{"duration":209.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":205.90000009536743,"connectEnd":205.90000009536743,"connectStart":205.90000009536743,"domainLookupEnd":205.90000009536743,"domainLookupStart":205.90000009536743,"fetchStart":205.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":277.90000009536743,"responseEnd":415.30000019073486,"responseStart":413.80000019073486,"secureConnectionStart":205.90000009536743},{"duration":31.700000286102295,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":206.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":206.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":237.80000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":211.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":206.30000019073486,"connectEnd":206.30000019073486,"connectStart":206.30000019073486,"domainLookupEnd":206.30000019073486,"domainLookupStart":206.30000019073486,"fetchStart":206.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":280.30000019073486,"responseEnd":417.90000009536743,"responseStart":415.69999980926514,"secureConnectionStart":206.30000019073486},{"duration":42.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":206.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":206.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":249,"responseStart":0,"secureConnectionStart":0},{"duration":223.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":206.59999990463257,"connectEnd":206.59999990463257,"connectStart":206.59999990463257,"domainLookupEnd":206.59999990463257,"domainLookupStart":206.59999990463257,"fetchStart":206.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":280.59999990463257,"responseEnd":429.69999980926514,"responseStart":418.30000019073486,"secureConnectionStart":206.59999990463257},{"duration":158.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":214,"connectEnd":341.30000019073486,"connectStart":341.30000019073486,"domainLookupEnd":341.30000019073486,"domainLookupStart":341.30000019073486,"fetchStart":214,"redirectEnd":0,"redirectStart":0,"requestStart":346.09999990463257,"responseEnd":372.19999980926514,"responseStart":365.09999990463257,"secureConnectionStart":341.30000019073486},{"duration":685.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":214,"connectEnd":214,"connectStart":214,"domainLookupEnd":214,"domainLookupStart":214,"fetchStart":214,"redirectEnd":0,"redirectStart":0,"requestStart":643.0999999046326,"responseEnd":899.5,"responseStart":888.0999999046326,"secureConnectionStart":214},{"duration":234.59999990463257,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":861.5,"connectEnd":861.5,"connectStart":861.5,"domainLookupEnd":861.5,"domainLookupStart":861.5,"fetchStart":861.5,"redirectEnd":0,"redirectStart":0,"requestStart":1061.3000001907349,"responseEnd":1096.0999999046326,"responseStart":1095.3000001907349,"secureConnectionStart":861.5},{"duration":126.39999961853027,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1165.3000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1165.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1291.6999998092651,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":51,"responseStart":199,"responseEnd":213,"domLoading":203,"domInteractive":1327,"domContentLoadedEventStart":1327,"domContentLoadedEventEnd":1375,"domComplete":1654,"loadEventStart":1654,"loadEventEnd":1654,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1293.5},{"name":"bigPipe.sidebar-id.end","time":1294.5999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":1294.8000001907349},{"name":"bigPipe.activity-panel-pipe-id.end","time":1296.6999998092651},{"name":"activityTabFullyLoaded","time":1393.1999998092651}],"measures":[],"correlationId":"a5f787a6c3e745","effectiveType":"4g","downlink":9.1,"rtt":0,"serverDuration":91,"dbReadsTimeInMs":13,"dbConnsTimeInMs":22,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Pushed