Details
-
Bug
-
Status: Open (View Workflow)
-
Major
-
Resolution: Unresolved
-
10.2.21, 10.3.12, 10.4(EOL)
-
None
Description
If MLOG_FILE_* redo log records works as expected during prepare phase then there is no need for extra tracking of ddl. Sample is that MLOG_FILE_RENAME2 didn't work as expected in prepare phase because mariabackup stores file name as "test/t1.ibd" but redo log stores "./test/t1.ibd". So fil_op_replay_rename() does string matching and fails.
Attachments
Issue Links
- relates to
-
MDEV-14992 BACKUP: in-server backup
-
- Open
-
-
MDEV-16791 mariabackup : allow consistent backup, in presence of concurrent DDL, also without --lock-ddl-per-table
-
- Closed
-
-
MDEV-18194 Incremental prepare tries to access page which is out of tablespace bounds.
-
- Closed
-
-
MDEV-24184 InnoDB RENAME TABLE recovery failure if names are reused
-
- Closed
-
We should also change mariabackup --prepare so that fil_name_parse() will actually delete files when processing MLOG_FILE_DELETE records, similar to how it renames files when processing MLOG_FILE_RENAME2. (If a file by the name exists, and the tablespace ID inside it matches, then delete the file.)
During normal crash recovery, MLOG_FILE_DELETE is informational and should not need to be applied, but I do not think that deleting files during recovery could hurt correctness.