Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-18045

Backporting the MDEV-15497 changes to 10.2 branch

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.2.23
    • Server
    • None

    Description

      It is necessary to backporting the changes which made to solve the MDEV-15497 problem to 10.2 branch and split the complex patch for the MDEV-17262 problem into two parts - to fix the same bugs (as in the MDEV-15497) in 10.2 branch and to speedup the MDEV-17262 code review.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          jplindst Jan Lindström (Inactive) added a comment -

          https://github.com/MariaDB/server/pull/1041

          jplindst Jan Lindström (Inactive) added a comment - https://github.com/MariaDB/server/pull/1041
          jplindst Jan Lindström (Inactive) added a comment -

          bar Can you please review this as this was originally your code.

          jplindst Jan Lindström (Inactive) added a comment - bar Can you please review this as this was originally your code.
          bar Alexander Barkov added a comment - - edited

          Hi Jan and Julius,

          the backport consisted of three patches:

          • MDEV-14628 Wrong autoinc value assigned by LOAD XML in the NO_AUTO_VALUE_ON_ZERO mode
          • MDEV-15497 Wrong empty value in a GEOMETRY column on LOAD DATA
          • MDEV-15597 Add class Load_data_outvar and avoid using Item::STRING_ITEM for Item_user_var_as_out_param detection

          To make sure the backport patch is OK, I cherry-picked all three patches to 10.2 one by one, and then compared
          the cumulative patch to the backport patch.
          The packport patch was missing two essential code chunks (and some unimportant cosmetics ones), and did not include mtr tests.

          So I decided just to push cherry-picked patches to 10.2.

          Please make sure to close the pull request:
          https://github.com/MariaDB/server/pull/1041

          bar Alexander Barkov added a comment - - edited Hi Jan and Julius, the backport consisted of three patches: MDEV-14628 Wrong autoinc value assigned by LOAD XML in the NO_AUTO_VALUE_ON_ZERO mode MDEV-15497 Wrong empty value in a GEOMETRY column on LOAD DATA MDEV-15597 Add class Load_data_outvar and avoid using Item::STRING_ITEM for Item_user_var_as_out_param detection To make sure the backport patch is OK, I cherry-picked all three patches to 10.2 one by one, and then compared the cumulative patch to the backport patch. The packport patch was missing two essential code chunks (and some unimportant cosmetics ones), and did not include mtr tests. So I decided just to push cherry-picked patches to 10.2. Please make sure to close the pull request: https://github.com/MariaDB/server/pull/1041

          People

            bar Alexander Barkov
            sysprg Julius Goryavsky
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.