[MDEV-18045] Backporting the MDEV-15497 changes to 10.2 branch Created: 2018-12-20  Updated: 2019-02-23  Resolved: 2019-02-23

Status: Closed
Project: MariaDB Server
Component/s: Server
Fix Version/s: 10.2.23

Type: Task Priority: Major
Reporter: Julius Goryavsky Assignee: Alexander Barkov
Resolution: Fixed Votes: 0
Labels: None


 Description   

It is necessary to backporting the changes which made to solve the MDEV-15497 problem to 10.2 branch and split the complex patch for the MDEV-17262 problem into two parts - to fix the same bugs (as in the MDEV-15497) in 10.2 branch and to speedup the MDEV-17262 code review.

 Comments   
Comment by Jan Lindström (Inactive) [ 2018-12-21 ]

https://github.com/MariaDB/server/pull/1041

Comment by Jan Lindström (Inactive) [ 2019-01-28 ]

bar Can you please review this as this was originally your code.

Comment by Alexander Barkov [ 2019-02-23 ]

Hi Jan and Julius,

the backport consisted of three patches:

  • MDEV-14628 Wrong autoinc value assigned by LOAD XML in the NO_AUTO_VALUE_ON_ZERO mode
  • MDEV-15497 Wrong empty value in a GEOMETRY column on LOAD DATA
  • MDEV-15597 Add class Load_data_outvar and avoid using Item::STRING_ITEM for Item_user_var_as_out_param detection

To make sure the backport patch is OK, I cherry-picked all three patches to 10.2 one by one, and then compared
the cumulative patch to the backport patch.
The packport patch was missing two essential code chunks (and some unimportant cosmetics ones), and did not include mtr tests.

So I decided just to push cherry-picked patches to 10.2.

Please make sure to close the pull request:
https://github.com/MariaDB/server/pull/1041

Generated at Thu Feb 08 08:41:05 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.