Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-17750

Remove dict_index_get_sys_col_pos() and some use of rec_get_offsets()

Details

    Description

      The function dict_index_get_sys_col_pos() is performing unnecessarily complex computations, which only make some sense for DB_ROW_ID, which would exist either as the first field in the clustered index or as the last field in a secondary index (only when a DB_ROW_ID column is materialised). We should add accessor functions dict_index_t::db_trx_id() and dict_index_t::db_roll_ptr().

      Also, there are some unnecessary calls to rec_get_offsets() when accessing the first field of a record, for accessing the columns DB_ROW_ID and FTS_DOC_ID.

      Attachments

        Activity

          This was motivated by code refactoring that I am working on in MDEV-17520.
          This could be easily backported to 10.2 or 10.3 if desired, for some performance benefit.

          marko Marko Mäkelä added a comment - This was motivated by code refactoring that I am working on in MDEV-17520 . This could be easily backported to 10.2 or 10.3 if desired, for some performance benefit.

          People

            marko Marko Mäkelä
            marko Marko Mäkelä
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.