[MDEV-17697] Broken versioning info after instant drop column - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.4(EOL)
Fix Version/s: 10.4.2
Component/s: Data Definition - Alter Table, Versioned Tables
Labels:
- affects-tests

Description

Assertion `col.vers_sys_end()' failed in dict_index_t::vers_history_row after dropping column

--source include/have_innodb.inc

CREATE TABLE t1 (a INT, b INT) ENGINE=InnoDB WITH SYSTEM VERSIONING;

INSERT INTO t1 VALUES (1,1);

SET SESSION system_versioning_alter_history= KEEP;

ALTER TABLE t1 DROP COLUMN b;

ALTER TABLE t1 DROP SYSTEM VERSIONING;

# Cleanup

DROP TABLE t1;

10.4 b5ac863f14
mysqld: /data/src/10.4/storage/innobase/dict/dict0mem.cc:1330: bool dict_index_t::vers_history_row(const rec_t, const ulint): Assertion `col.vers_sys_end()' failed.
181123 1:48:35 [ERROR] mysqld got signal 6 ;

#7 0x00007ff57c47eee2 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6
#8 0x0000559ebf3567c4 in dict_index_t::vers_history_row (this=0x7ff51c12df58, rec=0x7ff575fa007e "", offsets=0x7ff51c057e18) at /data/src/10.4/storage/innobase/dict/dict0mem.cc:1330
#9 0x0000559ebf1a85f5 in row_merge_read_clustered_index (trx=0x7ff5762bb118, table=0x7ff51c049620, old_table=0x7ff51c12b7f8, new_table=0x7ff51c12ca28, online=false, index=0x7ff51c0a90d0, fts_sort_idx=0x0, psort_info=0x0, files=0x7ff51c15f980, key_numbers=0x7ff51c0a90d8, n_index=1, defaults=0x0, add_v=0x0, col_map=0x7ff51c0a9128, add_autoinc=18446744073709551615, sequence=..., block=0x7ff574153000 "", skip_pk_sort=true, tmpfd=0x7ff5757c0da0, stage=0x7ff51c158ea0, pct_cost=50, crypt_block=0x0, eval_table=0x7ff51c049620, allow_not_null=false) at /data/src/10.4/storage/innobase/row/row0merge.cc:2330
#10 0x0000559ebf1af602 in row_merge_build_indexes (trx=0x7ff5762bb118, old_table=0x7ff51c12b7f8, new_table=0x7ff51c12ca28, online=false, indexes=0x7ff51c0a90d0, key_numbers=0x7ff51c0a90d8, n_indexes=1, table=0x7ff51c049620, defaults=0x0, col_map=0x7ff51c0a9128, add_autoinc=18446744073709551615, sequence=..., skip_pk_sort=true, stage=0x7ff51c158ea0, add_v=0x0, eval_table=0x7ff51c049620, allow_not_null=false) at /data/src/10.4/storage/innobase/row/row0merge.cc:4766
#11 0x0000559ebf099f0e in ha_innobase::inplace_alter_table (this=0x7ff51c12e8d8, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0) at /data/src/10.4/storage/innobase/handler/handler0alter.cc:8041
#12 0x0000559ebeb1571b in handler::ha_inplace_alter_table (this=0x7ff51c12e8d8, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0) at /data/src/10.4/sql/handler.h:4183
#13 0x0000559ebeb0ae46 in mysql_inplace_alter_table (thd=0x7ff51c000b00, table_list=0x7ff51c014e90, table=0x7ff51c131210, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0, inplace_supported=HA_ALTER_INPLACE_COPY_LOCK, target_mdl_request=0x7ff5757c1ce0, alter_ctx=0x7ff5757c28d0) at /data/src/10.4/sql/sql_table.cc:7555
#14 0x0000559ebeb10e8d in mysql_alter_table (thd=0x7ff51c000b00, new_db=0x7ff51c0051b8, new_name=0x7ff51c005588, create_info=0x7ff5757c34c0, table_list=0x7ff51c014e90, alter_info=0x7ff5757c3400, order_num=0, order=0x0, ignore=false) at /data/src/10.4/sql/sql_table.cc:9694
#15 0x0000559ebeb9a015 in Sql_cmd_alter_table::execute (this=0x7ff51c0154d0, thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_alter.cc:497
#16 0x0000559ebea394aa in mysql_execute_command (thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_parse.cc:6289
#17 0x0000559ebea3e3ce in mysql_parse (thd=0x7ff51c000b00, rawbuf=0x7ff51c014d98 "ALTER TABLE t1 DROP SYSTEM VERSIONING", length=37, parser_state=0x7ff5757c4600, is_com_multi=false, is_next_command=false) at /data/src/10.4/sql/sql_parse.cc:8091
#18 0x0000559ebea2b6cd in dispatch_command (command=COM_QUERY, thd=0x7ff51c000b00, packet=0x7ff51c093d91 "ALTER TABLE t1 DROP SYSTEM VERSIONING", packet_length=37, is_com_multi=false, is_next_command=false) at /data/src/10.4/sql/sql_parse.cc:1851
#19 0x0000559ebea2a0f1 in do_command (thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_parse.cc:1396
#20 0x0000559ebeb94294 in do_handle_one_connection (connect=0x559ec15becb0) at /data/src/10.4/sql/sql_connect.cc:1402
#21 0x0000559ebeb94018 in handle_one_connection (arg=0x559ec15becb0) at /data/src/10.4/sql/sql_connect.cc:1308
#22 0x0000559ebf03a1d9 in pfs_spawn_thread (arg=0x559ec1643f80) at /data/src/10.4/storage/perfschema/pfs.cc:1862
#23 0x00007ff57df3a494 in start_thread (arg=0x7ff5757c5700) at pthread_create.c:333
#24 0x00007ff57c53b93f in clone () from /lib/x86_64-linux-gnu/libc.so.6

Not reproducible on 10.3.

Attachments

Issue Links

causes

MDEV-20545 Assertion (col.vers_sys_end()) upon inplace ALTER with virtual columns

Closed

MDEV-29034 Assertion (o->ind == vers_start) upon inplace ALTER with virtual columns

Closed

is blocked by

MDEV-17899 Instant ADD/DROP multiple failure assertions

Closed

MDEV-18098 Crash after rollback of instant DROP COLUMN

Closed

relates to

MDEV-18173 Assertion `o->ind == vers_end' or `o->ind == vers_start' failed in dict_table_t::instant_column

Closed

Activity

Ascending order - Click to sort in descending order

Elena Stepanova created issue - 2018-11-13 12:50

Elena Stepanova made changes - 2018-11-22 23:49

Field	Original Value	New Value
Component/s		Data Definition - Alter Table [ 10114 ]
Fix Version/s		10.4 [ 22408 ]
Description	https://travis-ci.org/elenst/travis-tests/jobs/454064237 {noformat:title=10.4 fde5386d16df100b5ecc8a47f0616de25fd9116e} mysqld: /home/travis/src/storage/innobase/dict/dict0mem.cc:1324: bool dict_index_t::vers_history_row(const rec_t, const ulint): Assertion `col.vers_sys_end()' failed. 181112 23:56:16 [ERROR] mysqld got signal 6 ; /home/travis/server/bin/mysqld(+0xf1b5c6)[0x5644cda405c6] dict/dict0mem.cc:1325(dict_index_t::vers_history_row(unsigned char const, unsigned long const))[0x5644cd88fc81] row/row0merge.cc:2330(row_merge_read_clustered_index)[0x5644cd896e19] row/row0merge.cc:4766(row_merge_build_indexes(trx_t, dict_table_t, dict_table_t, bool, dict_index_t, unsigned long const, unsigned long, TABLE, dtuple_t const, unsigned long const, unsigned long, ib_sequence_t&, bool, ut_stage_alter_t, dict_add_v_col_t const, TABLE, bool))[0x5644cd77fca5] handler/handler0alter.cc:8041(ha_innobase::inplace_alter_table(TABLE, Alter_inplace_info))[0x5644cd304d9d] sql/handler.h:4184(handler::ha_inplace_alter_table(TABLE, Alter_inplace_info))[0x5644cd2fa4d0] sql/sql_table.cc:7555(mysql_inplace_alter_table)[0x5644cd300515] sql/sql_table.cc:9694(mysql_alter_table(THD, st_mysql_const_lex_string const, st_mysql_const_lex_string const, HA_CREATE_INFO, TABLE_LIST, Alter_info, unsigned int, st_order, bool))[0x5644cd38a040] sql/sql_alter.cc:497(Sql_cmd_alter_table::execute(THD))[0x5644cd2290f4] sql/sql_parse.cc:6289(mysql_execute_command(THD))[0x5644cd22dfdd] sql/sql_parse.cc:8091(mysql_parse(THD, char, unsigned int, Parser_state, bool, bool))[0x5644cd21b31c] sql/sql_parse.cc:1853(dispatch_command(enum_server_command, THD, char, unsigned int, bool, bool))[0x5644cd219d4d] sql/sql_parse.cc:1396(do_command(THD))[0x5644cd3843c8] sql/sql_connect.cc:1402(do_handle_one_connection(CONNECT))[0x5644cd38414c] /lib/x86_64-linux-gnu/libpthread.so.0(+0x8184)[0x7f96aa4f9184] /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x7f96a9a05ffd] Trying to get some variables. Some pointers may be invalid and cause the dump to abort. Query (0x5644d146e148): ALTER TABLE t4 DROP SYSTEM VERSIONING /* QNO 40245 CON_ID 15 */ Connection ID (thread ID): 15 Status: NOT_KILLED Optimizer switch: index_merge=on,index_merge_union=on,index_merge_sort_union=on,index_merge_intersection=on,index_merge_sort_intersection=off,engine_condition_pushdown=off,index_condition_pushdown=on,derived_merge=on,derived_with_keys=on,firstmatch=on,loosescan=on,materialization=on,in_to_exists=on,semijoin=on,partial_match_rowid_merge=on,partial_match_table_scan=on,subquery_cache=on,mrr=off,mrr_cost_based=off,mrr_sort_keys=off,outer_join_with_cache=on,semijoin_with_cache=on,join_cache_incremental=on,join_cache_hashed=on,join_cache_bka=on,optimize_join_buffer_size=off,table_elimination=on,extended_keys=on,exists_to_in=on,orderby_uses_equalities=on,condition_pushdown_for_derived=on,split_materialized=on,condition_pushdown_for_subquery=on {noformat} {noformat:title=elenst-dev efcc1f7ac786df9e0fb2d19a1ce252121b259848} perl ./runall-new.pl --basedir=/home/travis/server --vardir=/home/travis/logs/vardir --duration=350 --threads=6 --seed=1542066712 --reporters=Backtrace,ErrorLog,Deadlock --validators=TransformerNoComparator --views --redefine=conf/mariadb/alter_table.yy --redefine=conf/mariadb/sp.yy --redefine=conf/mariadb/bulk_insert.yy --redefine=conf/mariadb/versioning.yy --redefine=conf/mariadb/sequences.yy --mysqld=--log_output=FILE --mysqld=--max-statement-time=30 --mysqld=--lock-wait-timeout=10 --mysqld=--loose-innodb-lock-wait-timeout=5 --mysqld=--loose-debug_assert_on_not_freed_memory=0 --grammar=conf/mariadb/oltp-transactional.yy --gendata=conf/mariadb/oltp.zz --skip-gendata --gendata-advanced --vcols --transformers=ExecuteAsIntersect,ExecuteAsExcept,ExecuteAsCTE,ExecuteAsExecuteImmediate,ExecuteAsDeleteReturning,ExecuteAsInsertSelect,ExecuteAsUnion,ExecuteAsUpdateDelete,ExecuteAsView,ExecuteAsPreparedTwice {noformat}	{code:sql} --source include/have_innodb.inc CREATE TABLE t1 (a INT, b INT) ENGINE=InnoDB WITH SYSTEM VERSIONING; INSERT INTO t1 VALUES (1,1); SET SESSION system_versioning_alter_history= KEEP; ALTER TABLE t1 DROP COLUMN b; ALTER TABLE t1 DROP SYSTEM VERSIONING; # Cleanup DROP TABLE t1; {code} {noformat:title=10.4 b5ac863f14} mysqld: /data/src/10.4/storage/innobase/dict/dict0mem.cc:1330: bool dict_index_t::vers_history_row(const rec_t, const ulint): Assertion `col.vers_sys_end()' failed. 181123 1:48:35 [ERROR] mysqld got signal 6 ; #7 0x00007ff57c47eee2 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6 #8 0x0000559ebf3567c4 in dict_index_t::vers_history_row (this=0x7ff51c12df58, rec=0x7ff575fa007e "", offsets=0x7ff51c057e18) at /data/src/10.4/storage/innobase/dict/dict0mem.cc:1330 #9 0x0000559ebf1a85f5 in row_merge_read_clustered_index (trx=0x7ff5762bb118, table=0x7ff51c049620, old_table=0x7ff51c12b7f8, new_table=0x7ff51c12ca28, online=false, index=0x7ff51c0a90d0, fts_sort_idx=0x0, psort_info=0x0, files=0x7ff51c15f980, key_numbers=0x7ff51c0a90d8, n_index=1, defaults=0x0, add_v=0x0, col_map=0x7ff51c0a9128, add_autoinc=18446744073709551615, sequence=..., block=0x7ff574153000 "", skip_pk_sort=true, tmpfd=0x7ff5757c0da0, stage=0x7ff51c158ea0, pct_cost=50, crypt_block=0x0, eval_table=0x7ff51c049620, allow_not_null=false) at /data/src/10.4/storage/innobase/row/row0merge.cc:2330 #10 0x0000559ebf1af602 in row_merge_build_indexes (trx=0x7ff5762bb118, old_table=0x7ff51c12b7f8, new_table=0x7ff51c12ca28, online=false, indexes=0x7ff51c0a90d0, key_numbers=0x7ff51c0a90d8, n_indexes=1, table=0x7ff51c049620, defaults=0x0, col_map=0x7ff51c0a9128, add_autoinc=18446744073709551615, sequence=..., skip_pk_sort=true, stage=0x7ff51c158ea0, add_v=0x0, eval_table=0x7ff51c049620, allow_not_null=false) at /data/src/10.4/storage/innobase/row/row0merge.cc:4766 #11 0x0000559ebf099f0e in ha_innobase::inplace_alter_table (this=0x7ff51c12e8d8, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0) at /data/src/10.4/storage/innobase/handler/handler0alter.cc:8041 #12 0x0000559ebeb1571b in handler::ha_inplace_alter_table (this=0x7ff51c12e8d8, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0) at /data/src/10.4/sql/handler.h:4183 #13 0x0000559ebeb0ae46 in mysql_inplace_alter_table (thd=0x7ff51c000b00, table_list=0x7ff51c014e90, table=0x7ff51c131210, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0, inplace_supported=HA_ALTER_INPLACE_COPY_LOCK, target_mdl_request=0x7ff5757c1ce0, alter_ctx=0x7ff5757c28d0) at /data/src/10.4/sql/sql_table.cc:7555 #14 0x0000559ebeb10e8d in mysql_alter_table (thd=0x7ff51c000b00, new_db=0x7ff51c0051b8, new_name=0x7ff51c005588, create_info=0x7ff5757c34c0, table_list=0x7ff51c014e90, alter_info=0x7ff5757c3400, order_num=0, order=0x0, ignore=false) at /data/src/10.4/sql/sql_table.cc:9694 #15 0x0000559ebeb9a015 in Sql_cmd_alter_table::execute (this=0x7ff51c0154d0, thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_alter.cc:497 #16 0x0000559ebea394aa in mysql_execute_command (thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_parse.cc:6289 #17 0x0000559ebea3e3ce in mysql_parse (thd=0x7ff51c000b00, rawbuf=0x7ff51c014d98 "ALTER TABLE t1 DROP SYSTEM VERSIONING", length=37, parser_state=0x7ff5757c4600, is_com_multi=false, is_next_command=false) at /data/src/10.4/sql/sql_parse.cc:8091 #18 0x0000559ebea2b6cd in dispatch_command (command=COM_QUERY, thd=0x7ff51c000b00, packet=0x7ff51c093d91 "ALTER TABLE t1 DROP SYSTEM VERSIONING", packet_length=37, is_com_multi=false, is_next_command=false) at /data/src/10.4/sql/sql_parse.cc:1851 #19 0x0000559ebea2a0f1 in do_command (thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_parse.cc:1396 #20 0x0000559ebeb94294 in do_handle_one_connection (connect=0x559ec15becb0) at /data/src/10.4/sql/sql_connect.cc:1402 #21 0x0000559ebeb94018 in handle_one_connection (arg=0x559ec15becb0) at /data/src/10.4/sql/sql_connect.cc:1308 #22 0x0000559ebf03a1d9 in pfs_spawn_thread (arg=0x559ec1643f80) at /data/src/10.4/storage/perfschema/pfs.cc:1862 #23 0x00007ff57df3a494 in start_thread (arg=0x7ff5757c5700) at pthread_create.c:333 #24 0x00007ff57c53b93f in clone () from /lib/x86_64-linux-gnu/libc.so.6 {noformat} Not reproducible on 10.3.
Summary	[Draft] Assertion `col.vers_sys_end()' failed in dict_index_t::vers_history_row	Assertion `col.vers_sys_end()' failed in dict_index_t::vers_history_row after dropping column

Elena Stepanova made changes - 2018-11-22 23:49

Assignee

Elena Stepanova [ elenst ]

Alexander Krizhanovsky [ krizhanovsky ]

Alexander Krizhanovsky made changes - 2018-11-28 15:32

Assignee

Alexander Krizhanovsky [ krizhanovsky ]

Aleksey Midenok [ midenok ]

Elena Stepanova made changes - 2018-11-30 12:27

Labels

affects-tests

Aleksey Midenkov made changes - 2018-12-03 14:48

Status

Open [ 1 ]

In Progress [ 3 ]

Aleksey Midenkov made changes - 2018-12-03 14:48

Description

{code:sql}
--source include/have_innodb.inc

CREATE TABLE t1 (a INT, b INT) ENGINE=InnoDB WITH SYSTEM VERSIONING;
INSERT INTO t1 VALUES (1,1);
SET SESSION system_versioning_alter_history= KEEP;
ALTER TABLE t1 DROP COLUMN b;
ALTER TABLE t1 DROP SYSTEM VERSIONING;

# Cleanup
DROP TABLE t1;
{code}

{noformat:title=10.4 b5ac863f14}
mysqld: /data/src/10.4/storage/innobase/dict/dict0mem.cc:1330: bool dict_index_t::vers_history_row(const rec_t*, const ulint*): Assertion `col.vers_sys_end()' failed.
181123 1:48:35 [ERROR] mysqld got signal 6 ;

#7 0x00007ff57c47eee2 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6
#8 0x0000559ebf3567c4 in dict_index_t::vers_history_row (this=0x7ff51c12df58, rec=0x7ff575fa007e "", offsets=0x7ff51c057e18) at /data/src/10.4/storage/innobase/dict/dict0mem.cc:1330
#9 0x0000559ebf1a85f5 in row_merge_read_clustered_index (trx=0x7ff5762bb118, table=0x7ff51c049620, old_table=0x7ff51c12b7f8, new_table=0x7ff51c12ca28, online=false, index=0x7ff51c0a90d0, fts_sort_idx=0x0, psort_info=0x0, files=0x7ff51c15f980, key_numbers=0x7ff51c0a90d8, n_index=1, defaults=0x0, add_v=0x0, col_map=0x7ff51c0a9128, add_autoinc=18446744073709551615, sequence=..., block=0x7ff574153000 "", skip_pk_sort=true, tmpfd=0x7ff5757c0da0, stage=0x7ff51c158ea0, pct_cost=50, crypt_block=0x0, eval_table=0x7ff51c049620, allow_not_null=false) at /data/src/10.4/storage/innobase/row/row0merge.cc:2330
#10 0x0000559ebf1af602 in row_merge_build_indexes (trx=0x7ff5762bb118, old_table=0x7ff51c12b7f8, new_table=0x7ff51c12ca28, online=false, indexes=0x7ff51c0a90d0, key_numbers=0x7ff51c0a90d8, n_indexes=1, table=0x7ff51c049620, defaults=0x0, col_map=0x7ff51c0a9128, add_autoinc=18446744073709551615, sequence=..., skip_pk_sort=true, stage=0x7ff51c158ea0, add_v=0x0, eval_table=0x7ff51c049620, allow_not_null=false) at /data/src/10.4/storage/innobase/row/row0merge.cc:4766
#11 0x0000559ebf099f0e in ha_innobase::inplace_alter_table (this=0x7ff51c12e8d8, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0) at /data/src/10.4/storage/innobase/handler/handler0alter.cc:8041
#12 0x0000559ebeb1571b in handler::ha_inplace_alter_table (this=0x7ff51c12e8d8, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0) at /data/src/10.4/sql/handler.h:4183
#13 0x0000559ebeb0ae46 in mysql_inplace_alter_table (thd=0x7ff51c000b00, table_list=0x7ff51c014e90, table=0x7ff51c131210, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0, inplace_supported=HA_ALTER_INPLACE_COPY_LOCK, target_mdl_request=0x7ff5757c1ce0, alter_ctx=0x7ff5757c28d0) at /data/src/10.4/sql/sql_table.cc:7555
#14 0x0000559ebeb10e8d in mysql_alter_table (thd=0x7ff51c000b00, new_db=0x7ff51c0051b8, new_name=0x7ff51c005588, create_info=0x7ff5757c34c0, table_list=0x7ff51c014e90, alter_info=0x7ff5757c3400, order_num=0, order=0x0, ignore=false) at /data/src/10.4/sql/sql_table.cc:9694
#15 0x0000559ebeb9a015 in Sql_cmd_alter_table::execute (this=0x7ff51c0154d0, thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_alter.cc:497
#16 0x0000559ebea394aa in mysql_execute_command (thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_parse.cc:6289
#17 0x0000559ebea3e3ce in mysql_parse (thd=0x7ff51c000b00, rawbuf=0x7ff51c014d98 "ALTER TABLE t1 DROP SYSTEM VERSIONING", length=37, parser_state=0x7ff5757c4600, is_com_multi=false, is_next_command=false) at /data/src/10.4/sql/sql_parse.cc:8091
#18 0x0000559ebea2b6cd in dispatch_command (command=COM_QUERY, thd=0x7ff51c000b00, packet=0x7ff51c093d91 "ALTER TABLE t1 DROP SYSTEM VERSIONING", packet_length=37, is_com_multi=false, is_next_command=false) at /data/src/10.4/sql/sql_parse.cc:1851
#19 0x0000559ebea2a0f1 in do_command (thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_parse.cc:1396
#20 0x0000559ebeb94294 in do_handle_one_connection (connect=0x559ec15becb0) at /data/src/10.4/sql/sql_connect.cc:1402
#21 0x0000559ebeb94018 in handle_one_connection (arg=0x559ec15becb0) at /data/src/10.4/sql/sql_connect.cc:1308
#22 0x0000559ebf03a1d9 in pfs_spawn_thread (arg=0x559ec1643f80) at /data/src/10.4/storage/perfschema/pfs.cc:1862
#23 0x00007ff57df3a494 in start_thread (arg=0x7ff5757c5700) at pthread_create.c:333
#24 0x00007ff57c53b93f in clone () from /lib/x86_64-linux-gnu/libc.so.6
{noformat}

Not reproducible on 10.3.

Assertion `col.vers_sys_end()' failed in dict_index_t::vers_history_row after dropping column

{code:sql}
--source include/have_innodb.inc

CREATE TABLE t1 (a INT, b INT) ENGINE=InnoDB WITH SYSTEM VERSIONING;
INSERT INTO t1 VALUES (1,1);
SET SESSION system_versioning_alter_history= KEEP;
ALTER TABLE t1 DROP COLUMN b;
ALTER TABLE t1 DROP SYSTEM VERSIONING;

# Cleanup
DROP TABLE t1;
{code}

{noformat:title=10.4 b5ac863f14}
mysqld: /data/src/10.4/storage/innobase/dict/dict0mem.cc:1330: bool dict_index_t::vers_history_row(const rec_t*, const ulint*): Assertion `col.vers_sys_end()' failed.
181123 1:48:35 [ERROR] mysqld got signal 6 ;

#7 0x00007ff57c47eee2 in __assert_fail () from /lib/x86_64-linux-gnu/libc.so.6
#8 0x0000559ebf3567c4 in dict_index_t::vers_history_row (this=0x7ff51c12df58, rec=0x7ff575fa007e "", offsets=0x7ff51c057e18) at /data/src/10.4/storage/innobase/dict/dict0mem.cc:1330
#9 0x0000559ebf1a85f5 in row_merge_read_clustered_index (trx=0x7ff5762bb118, table=0x7ff51c049620, old_table=0x7ff51c12b7f8, new_table=0x7ff51c12ca28, online=false, index=0x7ff51c0a90d0, fts_sort_idx=0x0, psort_info=0x0, files=0x7ff51c15f980, key_numbers=0x7ff51c0a90d8, n_index=1, defaults=0x0, add_v=0x0, col_map=0x7ff51c0a9128, add_autoinc=18446744073709551615, sequence=..., block=0x7ff574153000 "", skip_pk_sort=true, tmpfd=0x7ff5757c0da0, stage=0x7ff51c158ea0, pct_cost=50, crypt_block=0x0, eval_table=0x7ff51c049620, allow_not_null=false) at /data/src/10.4/storage/innobase/row/row0merge.cc:2330
#10 0x0000559ebf1af602 in row_merge_build_indexes (trx=0x7ff5762bb118, old_table=0x7ff51c12b7f8, new_table=0x7ff51c12ca28, online=false, indexes=0x7ff51c0a90d0, key_numbers=0x7ff51c0a90d8, n_indexes=1, table=0x7ff51c049620, defaults=0x0, col_map=0x7ff51c0a9128, add_autoinc=18446744073709551615, sequence=..., skip_pk_sort=true, stage=0x7ff51c158ea0, add_v=0x0, eval_table=0x7ff51c049620, allow_not_null=false) at /data/src/10.4/storage/innobase/row/row0merge.cc:4766
#11 0x0000559ebf099f0e in ha_innobase::inplace_alter_table (this=0x7ff51c12e8d8, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0) at /data/src/10.4/storage/innobase/handler/handler0alter.cc:8041
#12 0x0000559ebeb1571b in handler::ha_inplace_alter_table (this=0x7ff51c12e8d8, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0) at /data/src/10.4/sql/handler.h:4183
#13 0x0000559ebeb0ae46 in mysql_inplace_alter_table (thd=0x7ff51c000b00, table_list=0x7ff51c014e90, table=0x7ff51c131210, altered_table=0x7ff51c049620, ha_alter_info=0x7ff5757c1bb0, inplace_supported=HA_ALTER_INPLACE_COPY_LOCK, target_mdl_request=0x7ff5757c1ce0, alter_ctx=0x7ff5757c28d0) at /data/src/10.4/sql/sql_table.cc:7555
#14 0x0000559ebeb10e8d in mysql_alter_table (thd=0x7ff51c000b00, new_db=0x7ff51c0051b8, new_name=0x7ff51c005588, create_info=0x7ff5757c34c0, table_list=0x7ff51c014e90, alter_info=0x7ff5757c3400, order_num=0, order=0x0, ignore=false) at /data/src/10.4/sql/sql_table.cc:9694
#15 0x0000559ebeb9a015 in Sql_cmd_alter_table::execute (this=0x7ff51c0154d0, thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_alter.cc:497
#16 0x0000559ebea394aa in mysql_execute_command (thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_parse.cc:6289
#17 0x0000559ebea3e3ce in mysql_parse (thd=0x7ff51c000b00, rawbuf=0x7ff51c014d98 "ALTER TABLE t1 DROP SYSTEM VERSIONING", length=37, parser_state=0x7ff5757c4600, is_com_multi=false, is_next_command=false) at /data/src/10.4/sql/sql_parse.cc:8091
#18 0x0000559ebea2b6cd in dispatch_command (command=COM_QUERY, thd=0x7ff51c000b00, packet=0x7ff51c093d91 "ALTER TABLE t1 DROP SYSTEM VERSIONING", packet_length=37, is_com_multi=false, is_next_command=false) at /data/src/10.4/sql/sql_parse.cc:1851
#19 0x0000559ebea2a0f1 in do_command (thd=0x7ff51c000b00) at /data/src/10.4/sql/sql_parse.cc:1396
#20 0x0000559ebeb94294 in do_handle_one_connection (connect=0x559ec15becb0) at /data/src/10.4/sql/sql_connect.cc:1402
#21 0x0000559ebeb94018 in handle_one_connection (arg=0x559ec15becb0) at /data/src/10.4/sql/sql_connect.cc:1308
#22 0x0000559ebf03a1d9 in pfs_spawn_thread (arg=0x559ec1643f80) at /data/src/10.4/storage/perfschema/pfs.cc:1862
#23 0x00007ff57df3a494 in start_thread (arg=0x7ff5757c5700) at pthread_create.c:333
#24 0x00007ff57c53b93f in clone () from /lib/x86_64-linux-gnu/libc.so.6
{noformat}

Not reproducible on 10.3.

Aleksey Midenkov made changes - 2018-12-03 14:50

Summary

Assertion `col.vers_sys_end()' failed in dict_index_t::vers_history_row after dropping column

Lost versioning prtype after instant drop column

Aleksey Midenkov made changes - 2018-12-03 16:18

Summary

Lost versioning prtype after instant drop column

Broken versioning info after instant drop column

Aleksey Midenkov added a comment - 2018-12-03 17:15

Cause

Discrepancy between dict_table_t::cols order and dict_table_t::vers_start, vers_end.

Analysis

Fix

Update vers_start, vers_end when dict_table_t::cols order changes.

Aleksey Midenkov added a comment - 2018-12-03 17:15 Cause Discrepancy between dict_table_t::cols order and dict_table_t::vers_start , vers_end . Analysis Fix Update vers_start , vers_end when dict_table_t::cols order changes.

Aleksey Midenkov made changes - 2018-12-03 17:18

Assignee	Aleksey Midenok [ midenok ]	Marko Mäkelä [ marko ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Marko Mäkelä added a comment - 2018-12-04 12:59

I think that something needs to be adjusted in dict_table_t::rollback_instant() as well. Can you create an additional test case with some fault injection that causes the DROP COLUMN to be rolled back?

Marko Mäkelä added a comment - 2018-12-04 12:59 I think that something needs to be adjusted in dict_table_t::rollback_instant() as well. Can you create an additional test case with some fault injection that causes the DROP COLUMN to be rolled back?

Marko Mäkelä made changes - 2018-12-04 12:59

Assignee	Marko Mäkelä [ marko ]	Aleksey Midenok [ midenok ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Aleksey Midenkov made changes - 2018-12-04 14:36

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Aleksey Midenkov added a comment - 2018-12-05 08:13

Test case for instant rollback revealed ~~MDEV-17899~~.

Aleksey Midenkov added a comment - 2018-12-05 08:13 Test case for instant rollback revealed MDEV-17899 .

Aleksey Midenkov made changes - 2018-12-05 08:13

Link

This issue is blocked by ~~MDEV-17899~~ [ ~~MDEV-17899~~ ]

Aleksey Midenkov made changes - 2018-12-05 08:13

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Aleksey Midenkov added a comment - 2018-12-12 19:30 - edited

Encountered another bug in instant ALTER.

Aleksey Midenkov added a comment - 2018-12-12 19:30 - edited Encountered another bug in instant ALTER.

Aleksey Midenkov made changes - 2018-12-21 09:28

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Aleksey Midenkov made changes - 2018-12-21 10:09

Assignee	Aleksey Midenok [ midenok ]	Marko Mäkelä [ marko ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Marko Mäkelä added a comment - 2018-12-28 12:32

I filed ~~MDEV-18098~~ for the bug.

Marko Mäkelä added a comment - 2018-12-28 12:32 I filed MDEV-18098 for the bug.

Marko Mäkelä made changes - 2018-12-28 12:32

Link

This issue is blocked by ~~MDEV-18098~~ [ ~~MDEV-18098~~ ]

Marko Mäkelä made changes - 2018-12-28 14:28

issue.field.resolutiondate

2018-12-28 14:28:45.0

2018-12-28 14:28:45.05

Marko Mäkelä made changes - 2018-12-28 14:28

Fix Version/s		10.4.2 [ 23229 ]
Fix Version/s	10.4 [ 22408 ]
Resolution		Fixed [ 1 ]
Status	In Review [ 10002 ]	Closed [ 6 ]

Marko Mäkelä made changes - 2019-01-14 04:25

Link

This issue relates to ~~MDEV-18173~~ [ ~~MDEV-18173~~ ]

Sergei Golubchik made changes - 2021-12-06 21:48

Workflow

MariaDB v3 [ 90599 ]

MariaDB v4 [ 155195 ]

Marko Mäkelä made changes - 2022-07-25 10:29

Link

This issue causes ~~MDEV-29034~~ [ ~~MDEV-29034~~ ]

Aleksey Midenkov made changes - 2023-07-26 18:52

Link

This issue causes ~~MDEV-20545~~ [ ~~MDEV-20545~~ ]

People

Assignee:: Marko Mäkelä

Reporter:: Elena Stepanova

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2018-11-13 12:50

Updated:: 2023-07-26 18:52

Resolved:: 2018-12-28 14:28

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

Cause

Fix

People

Dates

Git Integration