Details
-
Task
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
-
None
Description
Remove page_id_t::m_fold. This was added as an optimization but my benchmark shows it actually slows things down. http://quick-bench.com/p9tQCIFqk2MJgBrK_vp80YD6r8Y
Updated page_id_t will be consisted of a two uint32_t. It can be transferred in one register in 64 bit platforms. So, pass it by value everywhere.
Attachments
Issue Links
- relates to
-
MDEV-23719 Make lock_sys use page_id_t
-
- Closed
-
Looks OK, but I’d request some related additional cleanup.
Also, I’d appreciate an example of the generated code for passing `page_id_t` by value on i386, amd64, aarch64. (I would like to confirm that it is only one 64-bit register or two 32-bit registers.)