Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-17346

parallel slave start and stop races to workers disappeared

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1(EOL)
    • 10.1.37
    • Replication
    • None

    Description

      The bug appears as a slave SQL thread hanging in
      rpl_parallel_thread_pool::get_thread() while there are no slave worker
      threads to awake it.

      The reason of the hang is that at the parallel slave worker pool
      activation the being stared SQL thread could read the worker pool size
      concurrently with pool deactivation. At reading the SQL thread did not
      employ necessary protection from a race.

      One way to fix it is to make the SQL thread at the pool activation first
      to grab the same lock as potential deactivator also does prior
      to access the pool size.

      Attachments

        Issue Links

          Activity

            knielsen Kristian Nielsen added a comment - Review done, patch is ok to push: https://lists.launchpad.net/maria-developers/msg11447.html
            Elkin Andrei Elkin added a comment -

            Pushed as f517d8c7425.

            Elkin Andrei Elkin added a comment - Pushed as f517d8c7425.

            People

              Elkin Andrei Elkin
              Elkin Andrei Elkin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.