Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-17098

DATE -> DATETIME replication conversion not working, even in ALL_NON_LOSSY mode

Details

    Description

      When having a DATE column on the master, a DATETIME column on the slave, and binlog_format=ROW, inserting into the table fails on the salve with:

      Last_SQL_Error: Column 1 of table 'test.t1' cannot be converted from type 'date' to type 'datetime'

      even with slave_type_conversions=ALL_NON_LOSSY, even though a conversion from a DATE to a DATETIME should be a lossles operation.

      In the MySQL 5.6 manual this conversion is listed as "not supported before 5.5.3". In the 5.7 and 5.8 versions of the manual this paragraph has been removed, but still DATE and DATETIME are missing from the list of supported operations.

      Our own documentation doesn't seem to mention supported conversion types at all.

      https://dev.mysql.com/doc/refman/5.6/en/replication-features-differing-tables.html

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17394 Row-based replication DATETIME(m) to DATETIME(s) does not work or incorrect

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32805 replication from timestamp to datetime cannot succeed (even with slave_type_conversions='ALL_LOSSY')

          • Major - Major loss of function.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            elenst Elena Stepanova added a comment -

            Reproducible easily, I'll leave it to Elkin to decide whether it needs to be fixed, or documented, or both.

            elenst Elena Stepanova added a comment - Reproducible easily, I'll leave it to Elkin to decide whether it needs to be fixed, or documented, or both.
            Elkin Andrei Elkin added a comment -

            Hello, Alexander!

            The latest patch is ready for your review and is available in the commit list as well as
            on bb-10.2-andrei.

            Cheers,

            Andrei

            Elkin Andrei Elkin added a comment - Hello, Alexander! The latest patch is ready for your review and is available in the commit list as well as on bb-10.2-andrei. Cheers, Andrei
            bar Alexander Barkov added a comment -

            Hi Andrei,

            The patch
            https://github.com/mariadb/server/commit/9fa03e5295366f66499037e7aaeab342c9ea3887
            looks generally find for me.

            Please consider reusing these files for new tests:

            • mysql-test/suite/rpl/include/type_conversions.test
            • mysql-test/suite/rpl/include/rpl_typeconv.inc
            • mysql-test/suite/rpl/t/rpl_typeconv.test
            bar Alexander Barkov added a comment - Hi Andrei, The patch https://github.com/mariadb/server/commit/9fa03e5295366f66499037e7aaeab342c9ea3887 looks generally find for me. Please consider reusing these files for new tests: mysql-test/suite/rpl/include/type_conversions.test mysql-test/suite/rpl/include/rpl_typeconv.inc mysql-test/suite/rpl/t/rpl_typeconv.test
            Elkin Andrei Elkin added a comment -

            Alexander, the testing part is improved per your request. A new patch 0d5b469fc32 is available for double-checking (bb-10.2-andrei and commit-list). Thanks for checking! Andrei.

            Elkin Andrei Elkin added a comment - Alexander, the testing part is improved per your request. A new patch 0d5b469fc32 is available for double-checking (bb-10.2-andrei and commit-list). Thanks for checking! Andrei.
            bar Alexander Barkov added a comment -

            Andrei,

            Looks very good for me. Ok to push.
            Thanks for addressing proposed suggestions.

            bar Alexander Barkov added a comment - Andrei, Looks very good for me. Ok to push. Thanks for addressing proposed suggestions.
            Elkin Andrei Elkin added a comment -

            Patch 2308b9afec5 is pushed to 10.2.

            Elkin Andrei Elkin added a comment - Patch 2308b9afec5 is pushed to 10.2.

            People

              Elkin Andrei Elkin
              hholzgra Hartmut Holzgraefe
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.