-
Task
-
-
Major
-
Resolution:
Fixed
-
-
-
The code rewriting "datetime_field IS NULL" to "datetime_field='0000-00-00'" has tests for field_type():
class Item_func_isnull :public Item_func_null_predicate
|
{
|
..
|
bool arg_is_datetime_notnull_field()
|
{
|
Item **args= arguments();
|
if (args[0]->real_item()->type() == Item::FIELD_ITEM)
|
{
|
Field *field=((Item_field*) args[0]->real_item())->field;
|
|
if (((field->type() == MYSQL_TYPE_DATE) ||
|
(field->type() == MYSQL_TYPE_DATETIME)) &&
|
(field->flags & NOT_NULL_FLAG))
|
return true;
|
}
|
..
|
};
|
COND *
|
Item_func_isnull::remove_eq_conds(THD *thd, Item::cond_result *cond_value,
|
bool top_level_arg)
|
{
|
..
|
if (((field->type() == MYSQL_TYPE_DATE) ||
|
(field->type() == MYSQL_TYPE_DATETIME)) &&
|
(field->flags & NOT_NULL_FLAG))
|
..
|
}
|
This is not friendly to new data types.
We'll remove these tests and add a new method in Type_handler_instead:
virtual bool cond_notnull_field_isnull_to_field_eq_zero() const
|
{
|
return false;
|
}
|
and override it for Type_handler_date_common and Type_handler_datetime_common to return true.
- blocks
-
MDEV-4912
Data type plugin API version 1
-
-
Closed
Alexander Barkov
made changes -
issue.field.resolutiondate
|
2018-08-03 03:56:24.0
|
2018-08-03 03:56:24.963
|
Alexander Barkov
made changes -
Fix Version/s
|
|
10.4.0
[ 23115
]
|
Fix Version/s
|
10.4
[ 22408
]
|
|
Resolution
|
|
Fixed
[ 1
]
|
Status
|
Open
[ 1
]
|
Closed
[ 6
]
|
Sergei Golubchik
made changes -
Workflow
|
MariaDB v3
[ 88725
]
|
MariaDB v4
[ 133648
]
|
{"report":{"fcp":1413.5,"ttfb":386.29999923706055,"pageVisibility":"visible","entityId":69008,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"ba0829c1-b211-4e4d-ab01-a01ebfa2f5cb","navigationType":0,"readyForUser":1514.8999996185303,"redirectCount":0,"resourceLoadedEnd":2590.8999996185303,"resourceLoadedStart":395.3999996185303,"resourceTiming":[{"duration":285.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":395.3999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":395.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":680.8999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":285.6000003814697,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":395.5999994277954,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":395.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":681.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":294,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":395.8999996185303,"connectEnd":395.8999996185303,"connectStart":395.8999996185303,"domainLookupEnd":395.8999996185303,"domainLookupStart":395.8999996185303,"fetchStart":395.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":395.8999996185303,"responseEnd":689.8999996185303,"responseStart":689.8999996185303,"secureConnectionStart":395.8999996185303},{"duration":401.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":396.0999994277954,"connectEnd":396.0999994277954,"connectStart":396.0999994277954,"domainLookupEnd":396.0999994277954,"domainLookupStart":396.0999994277954,"fetchStart":396.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":396.0999994277954,"responseEnd":797.3999996185303,"responseStart":797.3999996185303,"secureConnectionStart":396.0999994277954},{"duration":405.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":396.29999923706055,"connectEnd":396.29999923706055,"connectStart":396.29999923706055,"domainLookupEnd":396.29999923706055,"domainLookupStart":396.29999923706055,"fetchStart":396.29999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":396.29999923706055,"responseEnd":801.5999994277954,"responseStart":801.5999994277954,"secureConnectionStart":396.29999923706055},{"duration":405.8999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":396.5,"connectEnd":396.5,"connectStart":396.5,"domainLookupEnd":396.5,"domainLookupStart":396.5,"fetchStart":396.5,"redirectEnd":0,"redirectStart":0,"requestStart":396.5,"responseEnd":802.3999996185303,"responseStart":802.3999996185303,"secureConnectionStart":396.5},{"duration":406,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":396.69999980926514,"connectEnd":396.69999980926514,"connectStart":396.69999980926514,"domainLookupEnd":396.69999980926514,"domainLookupStart":396.69999980926514,"fetchStart":396.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":396.69999980926514,"responseEnd":802.6999998092651,"responseStart":802.6999998092651,"secureConnectionStart":396.69999980926514},{"duration":458.4000005722046,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":396.79999923706055,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":396.79999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":855.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":406.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":397,"connectEnd":397,"connectStart":397,"domainLookupEnd":397,"domainLookupStart":397,"fetchStart":397,"redirectEnd":0,"redirectStart":0,"requestStart":397,"responseEnd":803.6999998092651,"responseStart":803.6999998092651,"secureConnectionStart":397},{"duration":458.4000005722046,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":397.0999994277954,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":397.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":855.5,"responseStart":0,"secureConnectionStart":0},{"duration":407,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":397.29999923706055,"connectEnd":397.29999923706055,"connectStart":397.29999923706055,"domainLookupEnd":397.29999923706055,"domainLookupStart":397.29999923706055,"fetchStart":397.29999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":397.29999923706055,"responseEnd":804.2999992370605,"responseStart":804.2999992370605,"secureConnectionStart":397.29999923706055},{"duration":851.9000005722046,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":403.5999994277954,"connectEnd":403.5999994277954,"connectStart":403.5999994277954,"domainLookupEnd":403.5999994277954,"domainLookupStart":403.5999994277954,"fetchStart":403.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":403.5999994277954,"responseEnd":1255.5,"responseStart":1255.5,"secureConnectionStart":403.5999994277954},{"duration":2187.199999809265,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":403.69999980926514,"connectEnd":403.69999980926514,"connectStart":403.69999980926514,"domainLookupEnd":403.69999980926514,"domainLookupStart":403.69999980926514,"fetchStart":403.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":403.69999980926514,"responseEnd":2590.8999996185303,"responseStart":2590.8999996185303,"secureConnectionStart":403.69999980926514},{"duration":309.0999994277954,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":947,"connectEnd":947,"connectStart":947,"domainLookupEnd":947,"domainLookupStart":947,"fetchStart":947,"redirectEnd":0,"redirectStart":0,"requestStart":947,"responseEnd":1256.0999994277954,"responseStart":1256.0999994277954,"secureConnectionStart":947},{"duration":1373.8999996185303,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1315.3999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1315.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2689.2999992370605,"responseStart":0,"secureConnectionStart":0},{"duration":1384.8000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":1316.7999992370605,"connectEnd":1316.7999992370605,"connectStart":1316.7999992370605,"domainLookupEnd":1316.7999992370605,"domainLookupStart":1316.7999992370605,"fetchStart":1316.7999992370605,"redirectEnd":0,"redirectStart":0,"requestStart":1316.7999992370605,"responseEnd":2701.5999994277954,"responseStart":2701.5999994277954,"secureConnectionStart":1316.7999992370605},{"duration":1390.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":1317.0999994277954,"connectEnd":1317.0999994277954,"connectStart":1317.0999994277954,"domainLookupEnd":1317.0999994277954,"domainLookupStart":1317.0999994277954,"fetchStart":1317.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":1317.0999994277954,"responseEnd":2707.5999994277954,"responseStart":2707.5999994277954,"secureConnectionStart":1317.0999994277954}],"fetchStart":1,"domainLookupStart":1,"domainLookupEnd":1,"connectStart":1,"connectEnd":1,"requestStart":176,"responseStart":387,"responseEnd":404,"domLoading":394,"domInteractive":2624,"domContentLoadedEventStart":2624,"domContentLoadedEventEnd":2690,"domComplete":4838,"loadEventStart":4839,"loadEventEnd":4839,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2598.5999994277954},{"name":"bigPipe.sidebar-id.end","time":2599.3999996185303},{"name":"bigPipe.activity-panel-pipe-id.start","time":2599.5999994277954},{"name":"bigPipe.activity-panel-pipe-id.end","time":2601.3999996185303},{"name":"activityTabFullyLoaded","time":2711.5999994277954}],"measures":[],"correlationId":"6c06b151c29804","effectiveType":"4g","downlink":9.2,"rtt":0,"serverDuration":123,"dbReadsTimeInMs":18,"dbConnsTimeInMs":34,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}