Details
-
Task
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
None
Description
Currently functions TIMESTAMP() and ADDTIME()/SUBTIME() reuse the same class Item_func_add_time.
We'll add a dedicated class for TIMESTAMP().
Rationale:
- Item_func_timestamp does not have to derive from Item_hybrid_func. It always returns a fixed data type (DATETIME for now).
- Soon we'll change TIMESTAMP() to return TIMESTAMP instead of DATETIME, so the underlying implementations will diverge anyway.
- Item_func_add_time will be simplified
Note, with the recently implemented class Sec6_add, there won't be duplicate code.
Attachments
Issue Links
- blocks
-
MDEV-4912 Data type plugin API version 1
-
- Closed
-
-
MDEV-15750 preserve MYSQL_TYPE_TIMESTAMP in temporal arithmetics
-
- Stalled
-
Activity
Link | This issue blocks MDEV-15750 [ MDEV-15750 ] |
issue.field.resolutiondate | 2018-07-31 12:58:49.0 | 2018-07-31 12:58:49.572 |
Fix Version/s | 10.4.0 [ 23115 ] | |
Fix Version/s | 10.4 [ 22408 ] | |
Resolution | Fixed [ 1 ] | |
Status | Open [ 1 ] | Closed [ 6 ] |
Workflow | MariaDB v3 [ 88665 ] | MariaDB v4 [ 133640 ] |