Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16849

Extending indexed VARCHAR column should be instantaneous

Details

    Description

      MySQL 5.7 (which was merged to MariaDB 10.2.2) implements an instantaneous change of the maximum length of a VARCHAR column when the length is increasing and not crossing the 255-byte boundary.

      Alas, when the VARCHAR column was indexed, the indexes would be dropped and added. This should be avoided.

      MySQL 5.7.23 addressed this by changing the storage engine API. We would prefer a less intrusive change. InnoDB should be able to ‘optimize away’ pairs of DROP INDEX and ADD INDEX operations. (While doing that, InnoDB in MariaDB should support the renaming of indexes as well, without introducing the RENAME INDEX syntax from MySQL 5.7.)

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-11424 Instant ALTER TABLE of failure-free record format changes

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is duplicated by

          Task - A task that needs to be done. MDEV-17965 Allow instant VARCHAR increase of indexed fields

          • Major - Major loss of function.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-15563 Instant failure-free data type conversions

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-16850 Merge new release of InnoDB 5.7.23 to 10.2

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Status Open [ 1 ] Confirmed [ 10101 ]
            marko Marko Mäkelä added a comment -

            While implementing this, please see if in ROW_FORMAT=REDUNDANT, we can also extend VARCHAR from any size to any size. The limitation regarding the 255-byte maximum length only applies to other ROW_FORMAT.

            marko Marko Mäkelä added a comment - While implementing this, please see if in ROW_FORMAT=REDUNDANT , we can also extend VARCHAR  from any size to any size. The limitation regarding the 255-byte maximum length only applies to other ROW_FORMAT .
            marko Marko Mäkelä made changes -
            Assignee Marko Mäkelä [ marko ] Thirunarayanan Balathandayuthapani [ thiru ]
            marko Marko Mäkelä made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Epic Link PT-80 [ 68561 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Fix Version/s 10.4 [ 22408 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Team Server DEV
            thiru Thirunarayanan Balathandayuthapani made changes -
            Status Confirmed [ 10101 ] In Progress [ 3 ]
            marko Marko Mäkelä added a comment -

            Somehow, the commit in MySQL 5.7.23 was cherry-picked and pushed to 5.7.24. These commits are equivalent according to the output of the following command:

            diff -u <(git show 913071c0b16cc03e703308250d795bc381627e37) <(git show 005ef9f0ed06df640503afaf65491205c422104b)

            marko Marko Mäkelä added a comment - Somehow, the commit in MySQL 5.7.23 was cherry-picked and pushed to 5.7.24 . These commits are equivalent according to the output of the following command: diff -u <(git show 913071c0b16cc03e703308250d795bc381627e37) <(git show 005ef9f0ed06df640503afaf65491205c422104b)
            thiru Thirunarayanan Balathandayuthapani added a comment -

            Patch is in bb-10.2-MDEV-16849

            thiru Thirunarayanan Balathandayuthapani added a comment - Patch is in bb-10.2-MDEV-16849
            thiru Thirunarayanan Balathandayuthapani made changes -
            Assignee Thirunarayanan Balathandayuthapani [ thiru ] Marko Mäkelä [ marko ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            marko Marko Mäkelä added a comment -

            There is only a trivial change to InnoDB; the rest is done in the SQL layer.
            The MySQL patch is bigger, changing all storage engines.

            marko Marko Mäkelä added a comment - There is only a trivial change to InnoDB; the rest is done in the SQL layer. The MySQL patch is bigger, changing all storage engines.
            marko Marko Mäkelä made changes -
            Assignee Marko Mäkelä [ marko ] Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Thirunarayanan Balathandayuthapani [ thiru ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            thiru Thirunarayanan Balathandayuthapani made changes -
            Assignee Thirunarayanan Balathandayuthapani [ thiru ] Sergei Golubchik [ serg ]
            Status Stalled [ 10000 ] In Review [ 10002 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Thirunarayanan Balathandayuthapani [ thiru ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            thiru Thirunarayanan Balathandayuthapani made changes -
            Assignee Thirunarayanan Balathandayuthapani [ thiru ] Sergei Golubchik [ serg ]
            Status Stalled [ 10000 ] In Review [ 10002 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Thirunarayanan Balathandayuthapani [ thiru ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            kevg Eugene Kosov (Inactive) made changes -
            thiru Thirunarayanan Balathandayuthapani made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            thiru Thirunarayanan Balathandayuthapani made changes -
            Assignee Thirunarayanan Balathandayuthapani [ thiru ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Thirunarayanan Balathandayuthapani [ thiru ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            thiru Thirunarayanan Balathandayuthapani made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            thiru Thirunarayanan Balathandayuthapani added a comment -

            Addressed the review comments.

            thiru Thirunarayanan Balathandayuthapani added a comment - Addressed the review comments.
            thiru Thirunarayanan Balathandayuthapani made changes -
            Assignee Thirunarayanan Balathandayuthapani [ thiru ] Sergei Golubchik [ serg ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ] Thirunarayanan Balathandayuthapani [ thiru ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            thiru Thirunarayanan Balathandayuthapani made changes -
            Fix Version/s 10.4.3 [ 23230 ]
            Fix Version/s 10.3.13 [ 23215 ]
            Fix Version/s 10.2.22 [ 23250 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 88638 ] MariaDB v4 [ 154726 ]

            People

              thiru Thirunarayanan Balathandayuthapani
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.