Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16613

rocksdb.rpl_row_stats fails in current 10.2

Details

    Description

      After some recent push, rocksdb.rpl_row_stats fails like so:

      CURRENT_TEST: rocksdb.rpl_row_stats
      --- /home/psergey/dev-git/10.2-r11/storage/rocksdb/mysql-test/rocksdb/r/rpl_row_stats.result    2018-05-07 20:41:05.397038779 +0300
      +++ /home/psergey/dev-git/10.2-r11/storage/rocksdb/mysql-test/rocksdb/r/rpl_row_stats.reject    2018-06-28 15:09:10.108019998 +0300
      @@ -53,7 +56,7 @@
       connection slave;
       call get_read_stats();
       rows_read_userstat
      -2
      +4
       rows_read
       2
       rows_updated
      @@ -79,7 +82,7 @@
       connection slave;
       call get_read_stats();
       rows_read_userstat
      -2
      +4
       rows_read
       2
       rows_updated
      

      Attachments

        Activity

          It seems to do the same number of updates, but the new tree increments
          the counter twice:

          AAA: start
          AAA: (t1) ha_rnd_pos_by_record
          AAA (t1):   rows_read++
          AAA (t1):   rows_read++
          AAA: (t1) ha_rnd_pos_by_record ends(0)
          AAA (gtid_slave_pos):   rows_read++
          AAA: (t1) ha_rnd_pos_by_record
          AAA (t1):   rows_read++
          AAA (t1):   rows_read++
          AAA: (t1) ha_rnd_pos_by_record ends(0)
          AAA (gtid_slave_pos):   rows_read++
          AAA: end
          

          On an older tree (a107c79fcdde80d1dea0a1caf5859647f77b48c9) I get:

          AAA: start
          AAA: (t1) ha_rnd_pos_by_record
          AAA (t1):   rows_read++
          AAA: (t1) ha_rnd_pos_by_record ends(0)
          AAA (gtid_slave_pos):   rows_read++
          AAA: (t1) ha_rnd_pos_by_record
          AAA (t1):   rows_read++
          AAA: (t1) ha_rnd_pos_by_record ends(0)
          AAA (gtid_slave_pos):   rows_read++
          AAA: end
          

          psergei Sergei Petrunia added a comment - It seems to do the same number of updates, but the new tree increments the counter twice: AAA: start AAA: (t1) ha_rnd_pos_by_record AAA (t1): rows_read++ AAA (t1): rows_read++ AAA: (t1) ha_rnd_pos_by_record ends(0) AAA (gtid_slave_pos): rows_read++ AAA: (t1) ha_rnd_pos_by_record AAA (t1): rows_read++ AAA (t1): rows_read++ AAA: (t1) ha_rnd_pos_by_record ends(0) AAA (gtid_slave_pos): rows_read++ AAA: end On an older tree (a107c79fcdde80d1dea0a1caf5859647f77b48c9) I get: AAA: start AAA: (t1) ha_rnd_pos_by_record AAA (t1): rows_read++ AAA: (t1) ha_rnd_pos_by_record ends(0) AAA (gtid_slave_pos): rows_read++ AAA: (t1) ha_rnd_pos_by_record AAA (t1): rows_read++ AAA: (t1) ha_rnd_pos_by_record ends(0) AAA (gtid_slave_pos): rows_read++ AAA: end

          Note that the first one makes two rows_read increments between ha_rnd_pos_by_record and ha_rnd_pos_by_record end. The second one makes just one increment.

          psergei Sergei Petrunia added a comment - Note that the first one makes two rows_read increments between ha_rnd_pos_by_record and ha_rnd_pos_by_record end . The second one makes just one increment.

          People

            serg Sergei Golubchik
            psergei Sergei Petrunia
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.