Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16518

MYSQL57_GENERATED_FIELD: The code in TABLE_SHARE::init_from_binary_frm_image() is not safe

Details

    Description

      This problem is similar to MDEV-15834, but for a 10.2 specific code in the code branch for MYSQL57_GENERATED_FIELD:

      vcol_info_length= uint2korr(vcol_screen_pos + 1);
      		 
      ...
      		 
      DBUG_ASSERT(vcol_info_length);
      		 
      ...
      		 
      vcol_screen_pos+= vcol_info_length + MYSQL57_GCOL_HEADER_SIZE;

      In case of a broke FRM file, this can crash in the debug build or behave unpredictably in a release build.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-15834 The code in TABLE_SHARE::init_from_binary_frm_image() is not safe

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            bar Alexander Barkov made changes -
            Attachment t1.frm [ 47993 ]
            bar Alexander Barkov made changes -
            Attachment t1.frm [ 47993 ]
            bar Alexander Barkov made changes -
            Attachment mdev16518.frm [ 47994 ]
            bar Alexander Barkov added a comment - - edited

            If I put the attached mdev16518.frm into mysql-test/std_data/frm, then this mtr test crashes on the mentioned DBUG_ASSERT:

            --copy_file std_data/frm/mdev16518.frm $MYSQLD_DATADIR/test/t1.frm
            		 
            SHOW TABLES;
            		 
            --replace_result $MYSQLD_DATADIR ./
            		 
            SHOW CREATE TABLE t1;

            bar Alexander Barkov added a comment - - edited If I put the attached mdev16518.frm into mysql-test/std_data/frm , then this mtr test crashes on the mentioned DBUG_ASSERT: --copy_file std_data/frm/mdev16518.frm $MYSQLD_DATADIR/test/t1.frm SHOW TABLES; --replace_result $MYSQLD_DATADIR ./ SHOW CREATE TABLE t1;
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2019-04-26 10:02:12.0 2019-04-26 10:02:12.986
            bar Alexander Barkov made changes -
            Fix Version/s 10.2.24 [ 23308 ]
            Fix Version/s 10.3.15 [ 23309 ]
            Fix Version/s 10.4.5 [ 23311 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 87913 ] MariaDB v4 [ 154533 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.