-
Task
-
-
Major
-
Resolution:
Fixed
-
-
-
In item_xmlfunc.cc there is a number of tests like:
if (item->type() == Item::XPATH_NODESET)
|
We'll modify this code in a more Type_handler-ish style, as follows:
- Remove XPATH_NODESET from the enum Item::Type.
- Add a new type handler declaration in item_xmlfunc.cc:
static Type_handler_long_blob type_handler_xpath_nodeset;
|
- Overload Item_nodeset_func::type_handler() and Item_nodeset_func::fixed_type_handler() to return &type_handler_xpath_nodeset.
- Change all tests for XPATH_NODESET to a test like this:
if (item->fixed_type_handler() == &type_handler_xpath_nodeset)
|
Additionally, we'll do the following cleanups:
- Rename the method Item::val_nodeset() to a more generic Item::val_raw(). It will be later used by other non-traditional data types.
- Remove XPATH_NODESET_CMP, as it's not used.
- blocks
-
MDEV-4912
Data type plugin API version 1
-
-
Closed
{"report":{"fcp":819.5999999046326,"ttfb":158.40000009536743,"pageVisibility":"visible","entityId":68004,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":32,"apdex":1,"journeyId":"88056f73-46b3-4c32-a708-546bc50e6690","navigationType":0,"readyForUser":902.0999999046326,"redirectCount":0,"resourceLoadedEnd":906.3000001907349,"resourceLoadedStart":164.7000002861023,"resourceTiming":[{"duration":161.89999961853027,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":164.7000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":164.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":326.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":161.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":165,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":165,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":326.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":170.89999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":165.2000002861023,"connectEnd":165.2000002861023,"connectStart":165.2000002861023,"domainLookupEnd":165.2000002861023,"domainLookupStart":165.2000002861023,"fetchStart":165.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":165.2000002861023,"responseEnd":336.09999990463257,"responseStart":336.09999990463257,"secureConnectionStart":165.2000002861023},{"duration":300.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":165.30000019073486,"connectEnd":165.30000019073486,"connectStart":165.30000019073486,"domainLookupEnd":165.30000019073486,"domainLookupStart":165.30000019073486,"fetchStart":165.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":165.30000019073486,"responseEnd":465.90000009536743,"responseStart":465.90000009536743,"secureConnectionStart":165.30000019073486},{"duration":310.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":165.59999990463257,"connectEnd":165.59999990463257,"connectStart":165.59999990463257,"domainLookupEnd":165.59999990463257,"domainLookupStart":165.59999990463257,"fetchStart":165.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":165.59999990463257,"responseEnd":476.09999990463257,"responseStart":476,"secureConnectionStart":165.59999990463257},{"duration":311,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":165.80000019073486,"connectEnd":165.80000019073486,"connectStart":165.80000019073486,"domainLookupEnd":165.80000019073486,"domainLookupStart":165.80000019073486,"fetchStart":165.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":165.80000019073486,"responseEnd":476.80000019073486,"responseStart":476.80000019073486,"secureConnectionStart":165.80000019073486},{"duration":311.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":166,"connectEnd":166,"connectStart":166,"domainLookupEnd":166,"domainLookupStart":166,"fetchStart":166,"redirectEnd":0,"redirectStart":0,"requestStart":166,"responseEnd":477.30000019073486,"responseStart":477.30000019073486,"secureConnectionStart":166},{"duration":314,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":166.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":166.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":480.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":312.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":166.30000019073486,"connectEnd":166.30000019073486,"connectStart":166.30000019073486,"domainLookupEnd":166.30000019073486,"domainLookupStart":166.30000019073486,"fetchStart":166.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":166.30000019073486,"responseEnd":478.40000009536743,"responseStart":478.40000009536743,"secureConnectionStart":166.30000019073486},{"duration":313.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":166.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":166.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":480.2000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":312.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":166.59999990463257,"connectEnd":166.59999990463257,"connectStart":166.59999990463257,"domainLookupEnd":166.59999990463257,"domainLookupStart":166.59999990463257,"fetchStart":166.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":166.59999990463257,"responseEnd":479.09999990463257,"responseStart":479.09999990463257,"secureConnectionStart":166.59999990463257},{"duration":379.2000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":167.5,"connectEnd":167.5,"connectStart":167.5,"domainLookupEnd":167.5,"domainLookupStart":167.5,"fetchStart":167.5,"redirectEnd":0,"redirectStart":0,"requestStart":167.5,"responseEnd":546.7000002861023,"responseStart":546.7000002861023,"secureConnectionStart":167.5},{"duration":738.7000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":167.59999990463257,"connectEnd":167.59999990463257,"connectStart":167.59999990463257,"domainLookupEnd":167.59999990463257,"domainLookupStart":167.59999990463257,"fetchStart":167.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":167.59999990463257,"responseEnd":906.3000001907349,"responseStart":906.3000001907349,"secureConnectionStart":167.59999990463257},{"duration":55.90000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":492,"connectEnd":492,"connectStart":492,"domainLookupEnd":492,"domainLookupStart":492,"fetchStart":492,"redirectEnd":0,"redirectStart":0,"requestStart":492,"responseEnd":547.9000000953674,"responseStart":547.9000000953674,"secureConnectionStart":492},{"duration":245.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2bv2/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":769.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":769.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1015.3000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":243.2000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":770.5,"connectEnd":770.5,"connectStart":770.5,"domainLookupEnd":770.5,"domainLookupStart":770.5,"fetchStart":770.5,"redirectEnd":0,"redirectStart":0,"requestStart":770.5,"responseEnd":1013.7000002861023,"responseStart":1013.7000002861023,"secureConnectionStart":770.5}],"fetchStart":1,"domainLookupStart":1,"domainLookupEnd":1,"connectStart":1,"connectEnd":1,"requestStart":5,"responseStart":159,"responseEnd":164,"domLoading":163,"domInteractive":963,"domContentLoadedEventStart":964,"domContentLoadedEventEnd":1008,"domComplete":1666,"loadEventStart":1666,"loadEventEnd":1667,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":951.3000001907349},{"name":"bigPipe.sidebar-id.end","time":952},{"name":"bigPipe.activity-panel-pipe-id.start","time":952.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":954.8000001907349},{"name":"activityTabFullyLoaded","time":1025.3000001907349}],"measures":[],"correlationId":"bf772eace3582a","effectiveType":"4g","downlink":9.9,"rtt":0,"serverDuration":92,"dbReadsTimeInMs":10,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}