Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16327

Server doesn't account for engines that supports OFFSET on their own.

Details

    Description

      It comes out that server doesn't honors group by handlers that supports OFFSET on their own and the server code in select_send::send_data tries to reapply OFFSET to the set returned by the handler[1]

      select i from t1 group by i limit 10,20; # Start from offset 10

      There is only engine that supports both group by handler and internal sorting ATM, so one could reproduce this only with columnstore engine built of:

      • develop branch columnstore fork of the server's code
      • develop branch columnstore engine

      1. https://hastebin.com/afepesalez.cs

      Attachments

        Issue Links

          is part of

          New Feature - A new feature of the product, which has yet to be developed. MCOL-1052 Implement GROUP BY pushdown support

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MCOL-3903 Performance regression in INSERT..SELECT

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-18553 Make LIMIT/OFFSET processing uniform

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            drrtuy Roman created issue -
            drrtuy Roman made changes -
            Field Original Value New Value
            serg Sergei Golubchik made changes -
            Assignee Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.2 [ 14601 ]
            serg Sergei Golubchik made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.2 [ 14601 ]
            drrtuy Roman made changes -
            Labels RM_104_CS_mandatory
            serg Sergei Golubchik made changes -
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.3 [ 22126 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Epic Link PT-81 [ 68562 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            Labels RM_104_CS_mandatory
            monty Michael Widenius made changes -
            Description It comes out that server doesn't honors group by handlers that supports OFFSET on their own and the server code in select_send::send_data tries to reapply OFFSET to the set returned by the handler[1]

            There is only engine that supports both group by handler and internal sorting ATM, so one could reproduce this only with columnstore engine built of:
            - develop branch columnstore fork of the server's code
            - develop branch columnstore engine

            1. https://hastebin.com/afepesalez.cs             		It comes out that server doesn't honors group by handlers that supports OFFSET on their own and the server code in select_send::send_data tries to reapply OFFSET to the set returned by the handler[1]

            select i from t1 group by i limit 10,20; # Start from offset 10

            There is only engine that supports both group by handler and internal sorting ATM, so one could reproduce this only with columnstore engine built of:
            - develop branch columnstore fork of the server's code
            - develop branch columnstore engine

            1. https://hastebin.com/afepesalez.cs
            ratzpo Rasmus Johansson (Inactive) made changes -
            Assignee Sergei Golubchik [ serg ] Oleksandr Byelkin [ sanja ]
            sanja Oleksandr Byelkin made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            sanja Oleksandr Byelkin added a comment - - edited

            monty, serg, drrtuy: Hi! As I can see (maybe I am wrong) group by handler do not signal what condition it accept and process (so we have to check HAVING twice for example), naturally it will not work for OFFSET, so I think of call like group_by_handler::is_limit_processed() (false by default) to remove LIMIT/OFFSET for the query if it will be processed by the engine. Is it OK?

            sanja Oleksandr Byelkin added a comment - - edited monty , serg , drrtuy : Hi! As I can see (maybe I am wrong) group by handler do not signal what condition it accept and process (so we have to check HAVING twice for example), naturally it will not work for OFFSET, so I think of call like group_by_handler::is_limit_processed() (false by default) to remove LIMIT/OFFSET for the query if it will be processed by the engine. Is it OK?
            sanja Oleksandr Byelkin made changes -
            Status In Progress [ 3 ] Stalled [ 10000 ]
            drrtuy Roman added a comment -

            According to comments in group_by_handler.h the handler instance signals whether it supports a feature or not but setting NULL to any Query structure's member that handler supports. But at this moment server crashes if I handler doesn't set NULL for any.
            If you find your way more suitable then the original then we should change the comments.

            drrtuy Roman added a comment - According to comments in group_by_handler.h the handler instance signals whether it supports a feature or not but setting NULL to any Query structure's member that handler supports. But at this moment server crashes if I handler doesn't set NULL for any. If you find your way more suitable then the original then we should change the comments.
            sanja Oleksandr Byelkin added a comment -

            if sorting supported it removed from Query

            sanja Oleksandr Byelkin added a comment - if sorting supported it removed from Query
            sanja Oleksandr Byelkin made changes -
            ralf.gebhardt Ralf Gebhardt made changes -
            Epic Link PT-81 [ 68562 ]
            ralf.gebhardt Ralf Gebhardt made changes -
            NRE Projects RM_104_CS_mandatory
            ralf.gebhardt Ralf Gebhardt made changes -
            Issue Type Task [ 3 ] Bug [ 1 ]
            sanja Oleksandr Byelkin made changes -
            Fix Version/s 10.5 [ 23123 ]
            Fix Version/s 10.4 [ 22408 ]
            sanja Oleksandr Byelkin made changes -
            Status Stalled [ 10000 ] In Progress [ 3 ]
            sanja Oleksandr Byelkin made changes -
            Issue Type Bug [ 1 ] Task [ 3 ]
            bar Alexander Barkov added a comment -

            Ok to push.

            bar Alexander Barkov added a comment - Ok to push.
            sanja Oleksandr Byelkin made changes -
            Component/s Optimizer [ 10200 ]
            Fix Version/s 10.5.0 [ 23709 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            drrtuy Roman made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 87559 ] MariaDB v4 [ 133565 ]

            People

              sanja Oleksandr Byelkin
              drrtuy Roman
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.