Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16250

Spider system tables are MyISAM and needs repair after a crash

Details

    Description

      If a crash occurs during the use of a spider table, the system tables for spiders needs to be repaired.

      Maybe the system tables for spider should be crash safe?

      show warnings;
      +-------+-------+------------------------------------------------------------------------------+
      | Level | Code  | Message                                                                      |
      +-------+-------+------------------------------------------------------------------------------+
      | Error |   145 | Table './mysql/spider_tables' is marked as crashed and should be repaired    |
      | Error |  1034 | 1 client is using or hasn't closed the table properly                        |
      | Error |   145 | Table './mysql/spider_table_sts' is marked as crashed and should be repaired |
      | Error |  1034 | 1 client is using or hasn't closed the table properly                        |
      | Error |   145 | Table './mysql/spider_table_crd' is marked as crashed and should be repaired |
      

      Attachments

        Issue Links

          Activity

            The standard system tables in the mysql database that use MyISAM are being converted to transactional Aria tables in 10.4.0, via the related task MDEV-16421. That is therefore the best time for the Spider system tables to be converted as well to transactional Aria tables.

            jacob-mathew Jacob Mathew (Inactive) added a comment - The standard system tables in the mysql database that use MyISAM are being converted to transactional Aria tables in 10.4.0, via the related task MDEV-16421 . That is therefore the best time for the Spider system tables to be converted as well to transactional Aria tables.

            During a server restart that follows a server crash, there may be error messages that indicate that certain system tables, including Spider system tables, are marked as crashed and may be corrupted. Upon checking the
            system tables that are marked as crashed, it may be found that there is no corruption that needs repair. However, the error messages that are issued imply that the user needs to nevertheless manually repair the system tables that were marked as crashed. These issues have been moved to a separate bug MDEV-17068.

            MDEV-16250 addresses the work to make the Spider system tables crash safe in 10.4 by using the Aria storage engine.

            jacob-mathew Jacob Mathew (Inactive) added a comment - During a server restart that follows a server crash, there may be error messages that indicate that certain system tables, including Spider system tables, are marked as crashed and may be corrupted. Upon checking the system tables that are marked as crashed, it may be found that there is no corruption that needs repair. However, the error messages that are issued imply that the user needs to nevertheless manually repair the system tables that were marked as crashed. These issues have been moved to a separate bug MDEV-17068 . MDEV-16250 addresses the work to make the Spider system tables crash safe in 10.4 by using the Aria storage engine.

            Kentoku, please review my fix in commit 73fac2a on my branch.

            jacob-mathew Jacob Mathew (Inactive) added a comment - Kentoku, please review my fix in commit 73fac2a on my branch .

            It's ok to push. Thanks.

            Kentoku Kentoku Shiba (Inactive) added a comment - It's ok to push. Thanks.

            Fix is pushed to 10.4.

            jacob-mathew Jacob Mathew (Inactive) added a comment - Fix is pushed to 10.4.

            People

              jacob-mathew Jacob Mathew (Inactive)
              mattiasjonsson Mattias Jonsson
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.