Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15945

--ps-protocol does not test some queries

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • 5.5(EOL), 10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL)
    • 10.2.23, 10.1.39, 10.3.14, 10.4.4
    • Tests
    • None

    Description

      --ps-protocol do not test:
      EXPLAIN
      ANALYSE
      CALL
      and so on

      List of what it test is here:

       const char *ps_re_str =
      		 
          "^("
      		 
          "[[:space:]]*REPLACE[[:space:]]|"
      		 
          "[[:space:]]*INSERT[[:space:]]|"
      		 
          "[[:space:]]*UPDATE[[:space:]]|"
      		 
          "[[:space:]]*DELETE[[:space:]]|"
      		 
          "[[:space:]]*SELECT[[:space:]]|"
      		 
          "[[:space:]]*CREATE[[:space:]]+TABLE[[:space:]]|"
      		 
          "[[:space:]]*DO[[:space:]]|"
      		 
          "[[:space:]]*SET[[:space:]]+OPTION[[:space:]]|"
      		 
          "[[:space:]]*DELETE[[:space:]]+MULTI[[:space:]]|"
      		 
          "[[:space:]]*UPDATE[[:space:]]+MULTI[[:space:]]|"
      		 
          "[[:space:]]*INSERT[[:space:]]+SELECT[[:space:]])";

      May be it has sense prohibit queries which has no sens, but allow all.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. MDEV-17302 Add support for ALTER USER command in prepared statement.

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          includes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17671 main.view fails in bb-10.4-ps branch in --ps

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17672 main.analyze_stmt fails in bb-10.4-ps branch in --ps

          • Major - Major loss of function.
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17673 main.cte_recursive fails in bb-10.4-ps branch in --ps

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18974 Result difference with --embedded --ps-protocol

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            sanja Oleksandr Byelkin created issue -
            sanja Oleksandr Byelkin made changes -
            Field Original Value New Value
            Description --ps-protocol do not test:
            EXPLAIN
            ANALYSE
            CALL
            and so on             		--ps-protocol do not test:
            EXPLAIN
            ANALYSE
            CALL
            and so on

            List of what it test is here:
            {code}
             const char *ps_re_str =
                "^("
                "[[:space:]]*REPLACE[[:space:]]|"
                "[[:space:]]*INSERT[[:space:]]|"
                "[[:space:]]*UPDATE[[:space:]]|"
                "[[:space:]]*DELETE[[:space:]]|"
                "[[:space:]]*SELECT[[:space:]]|"
                "[[:space:]]*CREATE[[:space:]]+TABLE[[:space:]]|"
                "[[:space:]]*DO[[:space:]]|"
                "[[:space:]]*SET[[:space:]]+OPTION[[:space:]]|"
                "[[:space:]]*DELETE[[:space:]]+MULTI[[:space:]]|"
                "[[:space:]]*UPDATE[[:space:]]+MULTI[[:space:]]|"
                "[[:space:]]*INSERT[[:space:]]+SELECT[[:space:]])";
            {code}

            May be it has sense prohibit queries which has no sens, but allow all.
            sanja Oleksandr Byelkin made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            sanja Oleksandr Byelkin made changes -
            Attachment MDEV-15945.diff [ 45523 ]
            sanja Oleksandr Byelkin added a comment -

            Problems:

            There are some statements which do not report error but do not work in PS (see attached diff)

            Even version comments hide command from detection.

            main.create_or_replace crash server on CREATE TABLE with an error (there are bug reports like this).

            sanja Oleksandr Byelkin added a comment - Problems: There are some statements which do not report error but do not work in PS (see attached diff) Even version comments hide command from detection. main.create_or_replace crash server on CREATE TABLE with an error (there are bug reports like this).
            sanja Oleksandr Byelkin made changes -
            Fix Version/s 10.4 [ 22408 ]
            Fix Version/s 10.3 [ 22126 ]
            serg Sergei Golubchik made changes -
            Assignee Oleksandr Byelkin [ sanja ] Sergei Golubchik [ serg ]
            serg Sergei Golubchik made changes -
            Status In Progress [ 3 ] Stalled [ 10000 ]
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            Fix Version/s 5.5 [ 15800 ]
            Fix Version/s 10.0 [ 16000 ]
            Fix Version/s 10.1 [ 16100 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.3 [ 22126 ]
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            Summary --ps-protocol do not test some queries --ps-protocol does not test some queries
            serg Sergei Golubchik made changes -
            Priority Major [ 3 ] Critical [ 2 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 5.5 [ 15800 ]
            Fix Version/s 10.0 [ 16000 ]
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            Fix Version/s 10.1.39 [ 23305 ]
            Fix Version/s 10.2.23 [ 23307 ]
            Fix Version/s 10.3.14 [ 23216 ]
            Fix Version/s 10.4.4 [ 23310 ]
            Fix Version/s 10.2 [ 14601 ]
            Fix Version/s 10.1 [ 16100 ]
            Fix Version/s 10.3 [ 22126 ]
            Fix Version/s 10.4 [ 22408 ]
            Resolution Fixed [ 1 ]
            Status Stalled [ 10000 ] Closed [ 6 ]
            marko Marko Mäkelä made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 86675 ] MariaDB v4 [ 154197 ]

            People

              serg Sergei Golubchik
              sanja Oleksandr Byelkin
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.