[MDEV-15945] --ps-protocol does not test some queries Created: 2018-04-20  Updated: 2019-03-20  Resolved: 2019-03-12

Status: Closed
Project: MariaDB Server
Component/s: Tests
Affects Version/s: 5.5, 10.0, 10.1, 10.2, 10.3
Fix Version/s: 10.2.23, 10.1.39, 10.3.14, 10.4.4

Type: Bug Priority: Critical
Reporter: Oleksandr Byelkin Assignee: Sergei Golubchik
Resolution: Fixed Votes: 1
Labels: None

Attachments: File MDEV-15945.diff    
Issue Links:
Blocks
blocks MDEV-17302 Add support for ALTER USER command in... Closed
is blocked by MDEV-17673 main.cte_recursive fails in bb-10.4-p... Closed
PartOf
includes MDEV-17671 main.view fails in bb-10.4-ps branch ... Closed
includes MDEV-17672 main.analyze_stmt fails in bb-10.4-ps... Closed
Relates
relates to MDEV-18974 Result difference with --embedded --p... Closed

 Description   

--ps-protocol do not test:
EXPLAIN
ANALYSE
CALL
and so on

List of what it test is here:

 const char *ps_re_str =
 
    "^("
 
    "[[:space:]]*REPLACE[[:space:]]|"
 
    "[[:space:]]*INSERT[[:space:]]|"
 
    "[[:space:]]*UPDATE[[:space:]]|"
 
    "[[:space:]]*DELETE[[:space:]]|"
 
    "[[:space:]]*SELECT[[:space:]]|"
 
    "[[:space:]]*CREATE[[:space:]]+TABLE[[:space:]]|"
 
    "[[:space:]]*DO[[:space:]]|"
 
    "[[:space:]]*SET[[:space:]]+OPTION[[:space:]]|"
 
    "[[:space:]]*DELETE[[:space:]]+MULTI[[:space:]]|"
 
    "[[:space:]]*UPDATE[[:space:]]+MULTI[[:space:]]|"
 
    "[[:space:]]*INSERT[[:space:]]+SELECT[[:space:]])";

May be it has sense prohibit queries which has no sens, but allow all.

 Comments   
Comment by Oleksandr Byelkin [ 2018-04-20 ]

Problems:

There are some statements which do not report error but do not work in PS (see attached diff)

Even version comments hide command from detection.

main.create_or_replace crash server on CREATE TABLE with an error (there are bug reports like this).

Generated at Thu Feb 08 08:25:12 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.