Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15736

mariadb-10.2.14/client/mysqladmin.cc:1586]: (style) Suspicious condition

    XMLWordPrintable

    Details

      Description

      mariadb-10.2.14/client/mysqladmin.cc:1586]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.

      Source code is

      if ((length=(uint) strlen(buff) > ex_val_max_len[row]) && ex_status_printed)

      Maybe better code

      if ((length=(uint) strlen(buff)) > ex_val_max_len[row] && ex_status_printed)

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              dcb David Binderman
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: