Details
-
Bug
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
-
5.5(EOL), 10.0(EOL), 10.1(EOL), 10.2(EOL), 10.3(EOL)
Description
[mariadb-10.2.14/client/mysqladmin.cc:1586]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
Source code is
if ((length=(uint) strlen(buff) > ex_val_max_len[row]) && ex_status_printed) |
Maybe better code
if ((length=(uint) strlen(buff)) > ex_val_max_len[row] && ex_status_printed) |
UPDATE
This is clearly operator precedence bug and should be resolved in this MDEV.
However, additional testing is needed for vertical option mysqladmin -E extended-status for mysqladmin, that is currently not working.
Validate the result with horizontal output mysqladmin --relative --sleep=1 extended-status | grep -v " 0 ", that should work.
Decide should we patch this feature or remove it, since it is not reported as non-working as part of new MDEV.