Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15730

mariabackup: rename --stream=xbstream to --stream=mbstream

Details

    Description

      The "xbstream" utility from XtraBackup has been renamed to "mbstream" in MariaDB Backup:

      [ec2-user@ip-172-30-0-58 ~]$ rpm -ql percona-xtrabackup-24 | grep stream
      		 
      /usr/bin/xbstream
      		 
      /usr/share/man/man1/xbstream.1.gz
      		 
      [ec2-user@ip-172-30-0-58 ~]$ rpm -ql MariaDB-backup | grep stream
      		 
      /usr/bin/mbstream

      However, the mariabackup utility still expects the "xbstream" value for the --stream argument:

      $ mariabackup --help
      		 
      mariabackup based on MariaDB server 10.2.14-MariaDB Linux (x86_64)
      		 
      Open source backup tool for InnoDB and XtraDB
      		 
      ...
      		 
        --stream=name       Stream all backup files to the standard output in the
      		 
                            specified format.Supported format is 'xbstream'.
      		 
      ...

      Maybe it would make sense to change this value to "mbstream" as well?

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-16883 MariaBackup very slow after upgrading from 10.2.14 to 10.3.8

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17601 MariaDB Galera does not expect 'mbstream' as streamfmt in the [sst] section and defaults to non-default 'tar'

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            wlad Vladislav Vaintroub added a comment -

            The format was not changed. mbstream utility is called so, because someone wanted to avoid name clashes with Percona utilities.
            why should be rename format ? What does it bring, except further incompatibilities

            wlad Vladislav Vaintroub added a comment - The format was not changed. mbstream utility is called so, because someone wanted to avoid name clashes with Percona utilities. why should be rename format ? What does it bring, except further incompatibilities
            ralf.gebhardt Ralf Gebhardt added a comment -

            Example documented here: https://mariadb.com/kb/en/library/mariabackup-options/#-stream

            ralf.gebhardt Ralf Gebhardt added a comment - Example documented here: https://mariadb.com/kb/en/library/mariabackup-options/#-stream
            sysprg Julius Goryavsky added a comment -

            Fixed,
            https://github.com/MariaDB/server/commit/81f94c26a4fb60345e260ba25f39315f3d9a6f3b
            http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.2-MDEV-15730-galera

            sysprg Julius Goryavsky added a comment - Fixed, https://github.com/MariaDB/server/commit/81f94c26a4fb60345e260ba25f39315f3d9a6f3b http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.2-MDEV-15730-galera
            jplindst Jan Lindström (Inactive) added a comment -

            ok to push

            jplindst Jan Lindström (Inactive) added a comment - ok to push
            sysprg Julius Goryavsky added a comment -

            Fixed

            sysprg Julius Goryavsky added a comment - Fixed

            People

              sysprg Julius Goryavsky
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.