[MDEV-15730] mariabackup: rename --stream=xbstream to --stream=mbstream Created: 2018-03-29  Updated: 2021-05-27  Resolved: 2021-05-25

Status: Closed
Project: MariaDB Server
Component/s: Backup, Galera SST
Affects Version/s: None
Fix Version/s: 10.6.2, 10.2.39, 10.3.30, 10.4.20, 10.5.11

Type: Bug Priority: Trivial
Reporter: Geoff Montee (Inactive) Assignee: Julius Goryavsky
Resolution: Fixed Votes: 1
Labels: mariabackup

Issue Links:
Relates
relates to MDEV-16883 MariaBackup very slow after upgrading... Closed
relates to MDEV-17601 MariaDB Galera does not expect 'mbstr... Closed

 Description   

The "xbstream" utility from XtraBackup has been renamed to "mbstream" in MariaDB Backup:

[ec2-user@ip-172-30-0-58 ~]$ rpm -ql percona-xtrabackup-24 | grep stream
/usr/bin/xbstream
/usr/share/man/man1/xbstream.1.gz
[ec2-user@ip-172-30-0-58 ~]$ rpm -ql MariaDB-backup | grep stream
/usr/bin/mbstream

However, the mariabackup utility still expects the "xbstream" value for the --stream argument:

$ mariabackup --help
mariabackup based on MariaDB server 10.2.14-MariaDB Linux (x86_64)
Open source backup tool for InnoDB and XtraDB
...
  --stream=name       Stream all backup files to the standard output in the
                      specified format.Supported format is 'xbstream'.
...

Maybe it would make sense to change this value to "mbstream" as well?



 Comments   
Comment by Vladislav Vaintroub [ 2018-05-28 ]

The format was not changed. mbstream utility is called so, because someone wanted to avoid name clashes with Percona utilities.
why should be rename format ? What does it bring, except further incompatibilities

Comment by Ralf Gebhardt [ 2018-05-28 ]

Example documented here: https://mariadb.com/kb/en/library/mariabackup-options/#-stream

Comment by Julius Goryavsky [ 2021-05-24 ]

Fixed,
https://github.com/MariaDB/server/commit/81f94c26a4fb60345e260ba25f39315f3d9a6f3b
http://buildbot.askmonty.org/buildbot/grid?category=main&branch=bb-10.2-MDEV-15730-galera

Comment by Jan Lindström (Inactive) [ 2021-05-25 ]

ok to push

Comment by Julius Goryavsky [ 2021-05-25 ]

Fixed

Generated at Thu Feb 08 08:23:35 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.