Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15696

Implement SHOW CREATE SERVER

Details

    Description

      CREATE SERVER is a valid statement in MariaDB:

      https://mariadb.com/kb/en/library/create-server/

      However, it seems like SHOW CREATE SERVER isn't implemented yet. Maybe it would be worth implementing?

      MariaDB [(none)]> CREATE SERVER srv1
      		 
          ->   FOREIGN DATA WRAPPER mysql
      		 
          -> OPTIONS(
      		 
          ->   HOST '172.30.0.58',
      		 
          ->   DATABASE 'db1',
      		 
          ->   USER 'maxscale',
      		 
          ->   PASSWORD 'password'
      		 
          -> );
      		 
      Query OK, 0 rows affected (0.00 sec)
      		 
       
      		 
      MariaDB [(none)]> SHOW CREATE SERVER srv1;
      		 
      ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'SERVER srv1' at line 1
      		 
      MariaDB [(none)]> SELECT * FROM mysql.servers\G
      		 
      *************************** 1. row ***************************
      		 
      Server_name: srv1
      		 
             Host: 172.30.0.58
      		 
               Db: db1
      		 
         Username: maxscale
      		 
         Password: password
      		 
             Port: 3306
      		 
           Socket:
      		 
          Wrapper: mysql
      		 
            Owner:
      		 
      1 row in set (0.00 sec)

      Attachments

        Issue Links

          blocks

          New Feature - A new feature of the product, which has yet to be developed. MDEV-34716 Allow arbitrary options in CREATE SERVER

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-35136 Sporadic hang on shutdown after using [SHOW] CREATE SERVER syntax

          • Major - Major loss of function.
          • Open
          includes

          New Feature - A new feature of the product, which has yet to be developed. MDEV-34716 Allow arbitrary options in CREATE SERVER

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is duplicated by

          Task - A task that needs to be done. MDEV-19559 Provide SHOW commands for SERVERs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-33196 [ERROR] Got error 12524 when reading table './test/t'

          • Major - Major loss of function.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            View 10 older comments
            Roel Roel Van de Paar added a comment - - edited

            ycp Before the change we had:

            CS 11.7.0 5bbda9711131845ae6b4315a268b4d1710943a85 (Optimized)

            		 
            11.7.0-opt>CREATE SERVER svr FOREIGN DATA WRAPPER mysql OPTIONS (HOST '127.0.0.1', DATABASE 'test', USER 'usr', PASSWORD 'pwd');
            		 
            Query OK, 0 rows affected (0.001 sec)
            		 
             
            		 
            11.7.0-opt>SELECT * FROM mysql.servers\G
            		 
            *************************** 1. row ***************************
            		 
            Server_name: svr
            		 
                   Host: 127.0.0.1
            		 
                     Db: test
            		 
               Username: usr
            		 
               Password: pwd
            		 
                   Port: 3306
            		 
                 Socket: 
                Wrapper: mysql
            		 
                  Owner: 
            1 row in set (0.000 sec)

            After we see:

            bb-11.7-mdev-15696 CS 11.7.0 f19446cc2cacfb7c78ce3c198042b86b4754321e (Optimized)

            		 
            11.7.0-opt>CREATE SERVER svr FOREIGN DATA WRAPPER mysql OPTIONS (HOST '127.0.0.1', DATABASE 'test', USER 'usr', PASSWORD 'pwd');
            		 
            Query OK, 0 rows affected (0.001 sec)
            		 
             
            		 
            11.7.0-opt>SELECT * FROM mysql.servers\G
            		 
            *************************** 1. row ***************************
            		 
            Server_name: svr
            		 
                   Host: 127.0.0.1
            		 
                     Db: test
            		 
               Username: usr
            		 
               Password: pwd
            		 
                   Port: 3306
            		 
                 Socket: 
                Wrapper: mysql
            		 
                  Owner: 
                Options: {"HOST": "127.0.0.1", "DATABASE": "test", "USER": "usr", "PASSWORD": "pwd"}
            		 
            1 row in set (0.000 sec)

            It looks like the values are duplicated into options? Is it necessary and can we avoid it?

            Roel Roel Van de Paar added a comment - - edited ycp Before the change we had: CS 11.7.0 5bbda9711131845ae6b4315a268b4d1710943a85 (Optimized) 11.7.0-opt>CREATE SERVER svr FOREIGN DATA WRAPPER mysql OPTIONS (HOST '127.0.0.1', DATABASE 'test', USER 'usr', PASSWORD 'pwd'); Query OK, 0 rows affected (0.001 sec)   11.7.0-opt>SELECT * FROM mysql.servers\G *************************** 1. row *************************** Server_name: svr Host: 127.0.0.1 Db: test Username: usr Password: pwd Port: 3306 Socket: Wrapper: mysql Owner: 1 row in set (0.000 sec) After we see: bb-11.7-mdev-15696 CS 11.7.0 f19446cc2cacfb7c78ce3c198042b86b4754321e (Optimized) 11.7.0-opt>CREATE SERVER svr FOREIGN DATA WRAPPER mysql OPTIONS (HOST '127.0.0.1', DATABASE 'test', USER 'usr', PASSWORD 'pwd'); Query OK, 0 rows affected (0.001 sec)   11.7.0-opt>SELECT * FROM mysql.servers\G *************************** 1. row *************************** Server_name: svr Host: 127.0.0.1 Db: test Username: usr Password: pwd Port: 3306 Socket: Wrapper: mysql Owner: Options: {"HOST": "127.0.0.1", "DATABASE": "test", "USER": "usr", "PASSWORD": "pwd"} 1 row in set (0.000 sec) It looks like the values are duplicated into options? Is it necessary and can we avoid it?
            ycp Yuchen Pei added a comment -

            Roel: it is a price to pay for backward compatibility

            ycp Yuchen Pei added a comment - Roel : it is a price to pay for backward compatibility
            Roel Roel Van de Paar added a comment -

            ycp ack, thank you

            Roel Roel Van de Paar added a comment - ycp ack, thank you
            Roel Roel Van de Paar added a comment -

            OK to push

            Roel Roel Van de Paar added a comment - OK to push
            ycp Yuchen Pei added a comment -

            Thanks for the testing Roel. Pushed the following to 11.7/main

            35cebfdc513 upstream/bb-11.7-mdev-15696 upstream/main MDEV-15696 Implement SHOW CREATE SERVER
            		 
            d2eba35653b MDEV-34716 Allow arbitrary options in CREATE SERVER
            		 
            2345407b8c2 MDEV-34716 Fix mysql.servers socket max length too short
            		 
            84df8d72751 MDEV-34716 spider: some trivial cleanups and documentation
            		 
            13cd8ad8db3 json_get_object_nkey() function implemented.

            ycp Yuchen Pei added a comment - Thanks for the testing Roel . Pushed the following to 11.7/main 35cebfdc513 upstream/bb-11.7-mdev-15696 upstream/main MDEV-15696 Implement SHOW CREATE SERVER d2eba35653b MDEV-34716 Allow arbitrary options in CREATE SERVER 2345407b8c2 MDEV-34716 Fix mysql.servers socket max length too short 84df8d72751 MDEV-34716 spider: some trivial cleanups and documentation 13cd8ad8db3 json_get_object_nkey() function implemented.

            People

              ycp Yuchen Pei
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.