Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-156

Threadpool - add thd_wait_begin/thd_wait_end to the network IO functions

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.0.2
    • None
    • None

    Description

      Certain types of workloads (large result sets, blobs, slow clients) can have longer waits on network io (socket reads and writes). Whenever server waits, this should be communicated to the threadpool, so it can start new query by either waking a waiting thread or sometimes creating a new one. IF threadpool does not know about blocking state of a thread, the performance will degrade.

      In MySQL prior to 5.6 it is not possible to know whether socket read or write would wait. In 5.6, socket handling on Unixes was changed in VIO. Sockets IO is always non-blocking and reads or writes that would block wait with poll() for operation to finish.

      The task is to add thd_wait_begin/thd_wait_end around these poll() calls.

      Attachments

        Activity

          This was assigned to me, which happens by default if no Assignee is given.

          ratzpo Rasmus Johansson (Inactive) added a comment - This was assigned to me, which happens by default if no Assignee is given.

          Davi's patch http://lists.mysql.com/commits/138456 is prerequisite for the task, need to check if it made into 10.0 yet

          wlad Vladislav Vaintroub added a comment - Davi's patch http://lists.mysql.com/commits/138456 is prerequisite for the task, need to check if it made into 10.0 yet

          Was it in 10.0?

          ratzpo Rasmus Johansson (Inactive) added a comment - Was it in 10.0?

          Yes, it is in 10.0 now. I have patch for the MDEV-156 , too somewhere, it is just not pushed anywhere yet, hopefully after 10.0.1 then

          wlad Vladislav Vaintroub added a comment - Yes, it is in 10.0 now. I have patch for the MDEV-156 , too somewhere, it is just not pushed anywhere yet, hopefully after 10.0.1 then

          People

            wlad Vladislav Vaintroub
            wlad Vladislav Vaintroub
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.