Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15128

Galera cluster synchronization fails when using custom decompressor with arguments

Details

    • 10.2.13

    Description

      Using:

      [sst]
      		 
      compressor=pigz
      		 
      decompressor='pigz -dc'

      ... makes synchronization fail with

      /usr//bin/wsrep_sst_common: line 275: [: pigz: binary operator expected

      The changes in 

      scripts/wsrep_sst_common.sh

      should have been made with double-quotes rounding the variables to prevent the shell from interpreting extra args applied to the (de)compressor command.
      https://github.com/MariaDB/server/commit/98e09ee4b624ded618124986fa0c04ef85e08cc0

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-15267 Bug in wsrep_sst_common

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-15512 Fix sh parse error when [sst] config value has spaces

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bmalynovytch Benjamin MALYNOVYTCH added a comment - - edited

            https: //github.com/MariaDB/server/pull/581
            https://github.com/MariaDB/server/pull/617

            bmalynovytch Benjamin MALYNOVYTCH added a comment - - edited https: //github.com/MariaDB/server/pull/581 https://github.com/MariaDB/server/pull/617
            bmalynovytch Benjamin MALYNOVYTCH added a comment -

            I've updated the pull request to base the fixes on 10.0-galera as suggested.
            10.2+ will need the same reworking to fix the new variables added after 10.0+

            Don't forget to update the milestone

            bmalynovytch Benjamin MALYNOVYTCH added a comment - I've updated the pull request to base the fixes on 10.0-galera as suggested. 10.2+ will need the same reworking to fix the new variables added after 10.0+ Don't forget to update the milestone
            sachin.setiya.007 Sachin Setiya (Inactive) added a comment -

            I do not think "" is required for [[

            Take this script for example
            It will print
            Equals
            Equals

            a='sa sa'
            		 
            b='sa sa'
            		 
            if [ "$a" = "$b" ]
            		 
            then
            		 
                echo "Equals"
            		 
            else
            		 
                echo "Not equals"
            		 
            fi
            		 
             
            		 
            if [[ $a = $b ]]
            		 
            then
            		 
                echo "Equals"
            		 
            else
            		 
                echo "Not equals"
            		 
            fi

            sachin.setiya.007 Sachin Setiya (Inactive) added a comment - I do not think "" is required for [[ Take this script for example It will print Equals Equals a= 'sa sa' b= 'sa sa' if [ "$a" = "$b" ] then echo "Equals" else echo "Not equals" fi   if [[ $a = $b ]] then echo "Equals" else echo "Not equals" fi
            seppo Seppo Jaakola added a comment -

            sst script seems to have been fixed as part of work done for related bugs (MDEV-15267)

            seppo Seppo Jaakola added a comment - sst script seems to have been fixed as part of work done for related bugs ( MDEV-15267 )

            People

              seppo Seppo Jaakola
              bmalynovytch Benjamin MALYNOVYTCH
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.